Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add campaign ID to button taps on campaign modal #4847

Merged
merged 2 commits into from
May 15, 2024
Merged

Add campaign ID to button taps on campaign modal #4847

merged 2 commits into from
May 15, 2024

Conversation

tonisevener
Copy link
Collaborator

Phabricator: https://phabricator.wikimedia.org/T352722

Notes

  • This PR adds the campaign_id in the action_data field for campaign button events.

Test Steps

  1. Change device region to Japan and device date to May 29th.
  2. Launch app on Staging. Background app on Explore feed. Foreground, then pull to refresh to fetch campaigns.
  3. Visit an article. Tap the Close button on campaign modal and confirm you see campaign_id listed out in the console for button tap event.
  4. Repeat steps 2-3 for other campaign modal buttons (donate, maybe later, I already donated), confirm campaign_id is now sent with event.

@tonisevener tonisevener requested review from a team and mazevedofs and removed request for a team May 7, 2024 16:41
Copy link
Collaborator

@mazevedofs mazevedofs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working great! I tried to fix the conflicts but I was messing something up, so just need to fix that and it can be merged

@mazevedofs mazevedofs merged commit acf5cc6 into main May 15, 2024
4 checks passed
@mazevedofs mazevedofs deleted the T352722 branch May 15, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants