Add Clamp to the description in gallery & Add Gallery item in Menu #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pr includes adding Gallery item into menu. |
hueitan
changed the title
stephanebisson
requested changes
Feb 5, 2020
|
can you give me the article name of your screenshot example? |
|
we cannot confirm the ellipsis at the end of the text in 3rd line, we can only insert
I'm thinking of another solution of having opacity in the bottom text between 3rd and 4th lines will try and see the possible way to do it then comment on phab. |
It's true, we have the same problem with clamping on the article title. I think we can let it go into QA and product sign off. |
stephanebisson
approved these changes
Feb 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
more than 3 lines.