Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the figure selectable and show gallery #138

Merged
merged 6 commits into from
Feb 20, 2020
Merged

Conversation

hueitan
Copy link
Member

@hueitan hueitan commented Feb 11, 2020

Phabricator Link : https://phabricator.wikimedia.org/T244841

Problem Statement

Currently, the gallery is available, but user unable to select image within the article page.

Solution

Let the figure (image) selectable and show the gallery with the selected image.

Note

Image Hover Not Hover
Capture Capture2

|

@hueitan hueitan requested a review from medied February 12, 2020 09:48
@hueitan hueitan marked this pull request as ready for review February 12, 2020 09:48
Copy link
Collaborator

@stephanebisson stephanebisson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think images in quick facts should be similarly selectable?

src/components/Article.js Outdated Show resolved Hide resolved
@hueitan
Copy link
Member Author

hueitan commented Feb 13, 2020

Quick fact image is now selectable! Thanks for the reminder @stephanebisson

.stylelintrc.json Outdated Show resolved Hide resolved
src/components/Article.js Outdated Show resolved Hide resolved
src/hooks/useArticleLinksNavigation.js Show resolved Hide resolved
style/article.less Outdated Show resolved Hide resolved
@jpita jpita merged commit 8a15644 into master Feb 20, 2020
@jpita jpita deleted the T244841-Selectable-Figure branch February 20, 2020 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants