Imagery definitions refactor #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- moveReaderToTag - now you can specify function which checks if tags are the same - getElementTextWithSubtags - returns the content of tag including all tags that may exist within
* make layer classes public * use WMTSCapabilities to pass general data (independent of layers) * make getCapabilities static * throw an exception if data is missing in document
* use SAX parser for WMS * use common parts with WMTS parser
* allow setting custom headers * allow setting default layer
don-vip
reviewed
May 3, 2018
| return layerName; | ||
| } | ||
|
|
||
| public String getTileMatrixSet() { |
There was a problem hiding this comment.
Can you please add Javadoc for all public methods?
don-vip
reviewed
May 3, 2018
| if (directory.length() + fileName.length() > 255) { | ||
| // Windows doesn't support paths longer than 260, leave 5 chars as safe buffer, 4 will be used by ".tmp" | ||
| // TODO: what about filename size on other systems? 255? | ||
| if (directory.length() > 191 && System.getProperty("os.name").toLowerCase().indexOf("win") >= 0) { |
There was a problem hiding this comment.
You should use Main.isPlatformWindows()
don-vip
reviewed
May 3, 2018
| } catch (NoSuchAlgorithmException e) { | ||
| Logging.error(e); | ||
| // TODO: what better can we do here? | ||
| throw new IllegalArgumentException("Missing digest algorithm SHA-256"); |
don-vip
reviewed
May 3, 2018
| @@ -111,71 +112,125 @@ public WMSGetCapabilitiesException(String message, String incomingData) { | |||
|
|
|||
| /** | |||
| * The data that caused this exception. | |||
| * @return The server response to the capabilities request. | |||
| * @return The server response to the capabilites request. | |||
don-vip
reviewed
May 3, 2018
| @@ -1,86 +1,86 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
This is only EOL change to unix.
don-vip
reviewed
May 3, 2018
| } | ||
|
|
||
| @Test | ||
| @Ignore("disabled as this needs user action") // XXX | ||
| //@Ignore("disabled as this needs user action") // XXX |
There was a problem hiding this comment.
if the test does not need user action any more, the line should be deleted, not commented
don-vip
reviewed
May 3, 2018
| "</imagery>" | ||
| ))); | ||
| mapsMock.start(); | ||
| // Main.pref.set |
don-vip
reviewed
May 3, 2018
| assertTrue(wms.getLayers().get(0).getAbstract().startsWith("South Carolina NAIP Imagery 2017 Resolution: 100CM ")); | ||
| wm.shutdown(); | ||
| } | ||
|
|
Make "valid georeference" and "custom http headers" visibile only in expert mode.
When no OperationsMetadata is provided assume REST style
|
merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://josm.openstreetmap.de/ticket/16249