Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFCORE-2565]: Incorrect permission class-name should throw exception at runtime #98

Closed

Conversation

ehsavoie
Copy link

Logging a WARNING when the class of a permission can't be loaded.

Jira: https://issues.jboss.org/browse/WFCORE-2565
JBEAP: https://issues.jboss.org/browse/JBEAP-9726

… at runtime

Logging a WARNING when the class of a permission can't be loaded.
@darranl
Copy link

darranl commented Mar 23, 2017

I think this is going to need some further thought, I have just checked and we do support 'UNLESS' within the mappings - this does mean a missing permission could inadvertently allow access that should not be granted.

@ehsavoie
Copy link
Author

Since we have our 'own' SimplePermissionWriteAttributeHandler we can put more logic in there.

@darranl
Copy link

darranl commented Mar 23, 2017

I think realistically we are going to have to keep the services failing start up if the permission is not found.

I am not really keen on adding a runtime handler just for the purpose of validating the permissions, especially on a resource that does not support runtime updates.

Maybe we would be better supporting runtime updates on the resource but most Elytron resources don't support this at the moment, it still doesn't cover the scenario of a slave connecting to the domain after the configuration has been updated so at best it would only ever be a partial validation.

@bstansberry
Copy link

Should this be closed?

@ehsavoie ehsavoie closed this Jun 23, 2017
@ehsavoie ehsavoie deleted the WFCORE-2565 branch October 6, 2017 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants