[ELY-2236] Updated README.md with link to Contribution guide #1608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, nimisha-yadav. I'm waiting for one of the admins to verify this patch with /ok-to-test in a comment. |
fjuma
reviewed
Oct 18, 2021
README.md
Outdated
| @@ -35,5 +35,6 @@ Contributions | |||
| ------------- | |||
|
|
|||
| All new features and enhancements should be submitted to 1.x branch only. | |||
|
|
|||
| https://wildfly-security.github.io/wildfly-elytron/getting-started-for-developers/ | |||
| Our [contribution guide](https://github.com/wildfly-security/wildfly-elytron/blob/1.x/CONTRIBUTING.md) will guide you through the steps for getting started on the Elytron Web project and will go through how to format and submit your first PR. | |||
There was a problem hiding this comment.
Just a small change needed. "Elytron Web project" should be "WildFly Elytron project"
nimisha-yadav
force-pushed
the
ELY-2236
branch
from
d3c00ad
to
7f5465d
Compare
fjuma
approved these changes
Oct 18, 2021
Skyllarr
approved these changes
Oct 19, 2021
|
@nimisha-yadav Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://issues.redhat.com/browse/ELY-2236