Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ELY-2704] Missing keystore password does not throw a meaningful exception #2123

Open
wants to merge 1 commit into
base: 2.x
Choose a base branch
from
Open

[ELY-2704] Missing keystore password does not throw a meaningful exception #2123

wants to merge 1 commit into from

Conversation

sudeshnas93
Copy link

@sudeshnas93 sudeshnas93 marked this pull request as ready for review April 8, 2024 09:27
@sudeshnas93
Copy link
Author

Hello @fjuma, @Skyllarr
could you please review this PR?
Thanks

ivassile
ivassile requested changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@ivassile ivassile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to log the warning before keyStore.load().
Create new message in ElytronMessages instead of xmlLog.warn() and log some specific information for the keyStore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivassile ivassile ivassile requested changes

@fjuma fjuma Awaiting requested review from fjuma fjuma is a code owner

@Skyllarr Skyllarr Awaiting requested review from Skyllarr Skyllarr is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@sudeshnas93 @ivassile