Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ELY-2704] Missing keystore password does not throw a meaningful exception #2123

Open
wants to merge 1 commit into
base: 2.x
Choose a base branch
from
Open

[ELY-2704] Missing keystore password does not throw a meaningful exception #2123

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions auth/client/src/main/java/org/wildfly/security/auth/client/ElytronXmlParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3652,6 +3652,11 @@ public KeyStore get() throws ConfigXMLParseException {
try (InputStream fis = createStream()) {
keyStore.load(fis, passwordFactory == null ? null : passwordFactory.get());
}
//warnings as keystore.load("",pass) won't fail
if (passwordFactory == null || passwordFactory.get() == null) {
//check for empty password
xmlLog.warn("No Keystore password specified, it is recommended to specify a keystore password for security.");
}
return keyStore;
} catch (GeneralSecurityException | IOException e) {
throw xmlLog.xmlFailedToLoadKeyStoreData(location, e);
Expand Down