Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ELY-587] SSL into DirContext #490

Merged
merged 2 commits into from
Sep 2, 2016
Merged

[ELY-587] SSL into DirContext #490

merged 2 commits into from
Sep 2, 2016

Conversation

thaarok
Copy link

@thaarok thaarok commented Aug 24, 2016

Based/depends on #487

  • DelegatingLdapContext now produced directly by SimpleDirContextFactoryBuilder
  • ElytronSSLSocketFactory ensure passing correct SocketFactory into DirContext
    • threadlocal is used to provide information about currently constructed DirContext into SocketFactory
    • threadlocal is set from DirContextFactory on build and on reconnect
    • into DelegatingLdapContext is passed callback, which allow do action (set threadlocal) before/after reconnect
  • in testing CA generated cert for "localhost", LDAPS used in tests now

@thaarok thaarok mentioned this pull request Aug 24, 2016
Closed
darranl
darranl reviewed Aug 25, 2016
View reviewed changes
src/main/java/org/wildfly/security/auth/realm/ldap/ElytronSSLSocketFactory.java
@@ -0,0 +1,81 @@
/*
* JBoss, Home of Professional Open Source.
* Copyright 2015 Red Hat, Inc., and individual contributors
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is 2016 ;-)

@darranl darranl added the +1 DAL label Aug 25, 2016
@thaarok
Copy link
Author

thaarok commented Aug 25, 2016

fixed header by note, added javadoc of ElytronSSLSocketFactory

dmlloyd
dmlloyd reviewed Aug 29, 2016
View reviewed changes
src/main/java/org/wildfly/security/auth/realm/ldap/ElytronSSLSocketFactory.java
*
* @author <a href="mailto:jkalina@redhat.com">Jan Kalina</a>
*/
public class ElytronSSLSocketFactory extends SocketFactory {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A better name for this would be "ThreadLocalSSLSocketFactory" IMO.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@thaarok thaarok mentioned this pull request Aug 29, 2016
Merged
@thaarok
Copy link
Author

thaarok commented Aug 29, 2016

Fixed by @dmlloyd's notes.

@dmlloyd dmlloyd added the +1 DML label Sep 2, 2016
@dmlloyd dmlloyd merged commit d9c5a9e into wildfly-security:master Sep 2, 2016
@thaarok thaarok deleted the ldap-ssl branch September 2, 2016 21:48
@thaarok thaarok mentioned this pull request Sep 2, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
+1 DAL +1 DML
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thaarok @dmlloyd @darranl