Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFLY-14563] todo-backend quickstart #477

Merged
merged 9 commits into from Apr 19, 2021

Conversation

jmesnil
Copy link
Member

@jmesnil jmesnil commented Mar 12, 2021

Add a new quickstart todo-backend to showcases a typical use of
WildFly: a backend that exposes a Web API (using JAX-RS) and connects to
a DB (using JPA).

The quickstart focuses on local and cloud deployment with Bootable Jar
and showcase the following features:

  • use the wildfly-datasources-galleon-pack to connect to an external
    PostgreSQL database
  • Execute a CLI script at build time to specialize the WildFly runtime
    provisioned by the Bootable Jar
  • Use of Helm Charts for cloud deployment

JIRA: https://issues.redhat.com/browse/WFLY-14563

Signed-off-by: Jeff Mesnil jmesnil@redhat.com

@jmesnil jmesnil marked this pull request as ready for review March 12, 2021 15:19
@jmesnil
Copy link
Member Author

jmesnil commented Mar 12, 2021

Dev analysis is at wildfly/wildfly-proposals#380

pom.xml Outdated Show resolved Hide resolved
todo-backend/README.adoc Outdated Show resolved Hide resolved
todo-backend/README.adoc Outdated Show resolved Hide resolved
todo-backend/todo-backend.yaml Outdated Show resolved Hide resolved
todo-backend/todo-backend.yaml Outdated Show resolved Hide resolved
todo-backend/todo-backend.yaml Outdated Show resolved Hide resolved
@jmesnil jmesnil force-pushed the WFLY-14563_todo-backend branch 2 times, most recently from dcd24c6 to 410ab52 Compare March 18, 2021 09:34
@jmesnil
Copy link
Member Author

jmesnil commented Mar 18, 2021

@jbliznak I replaced most occurrences of WildFly in the README with the {productName} macro. The remaining occurrences will be replaced manually when we add this quickstart to EAP quickstarts.

todo-backend/README.adoc Outdated Show resolved Hide resolved
README.adoc Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
@jmesnil jmesnil force-pushed the WFLY-14563_todo-backend branch 5 times, most recently from 1b54416 to 0aa0008 Compare March 19, 2021 14:05
@jmesnil jmesnil requested a review from emmartins March 22, 2021 12:58
Add a new quickstart `todo-backend` to showcases a typical use of
WildFly: a backend that exposes a Web API (using JAX-RS) and connects to
a DB (using JPA).

The quickstart focuses on local and cloud deployment with Bootable Jar
and cloud deployment with S2I.
It showcases  the following features:
* use the wildfly-datasources-galleon-pack to connect to an external
  PostgreSQL database
* [Bootable Jar] Execute a CLI script at build time to specialize the WildFly runtime
  provisioned by the Bootable Jar
* [Bootable Jar] Local deployment with a PostgreSQL Docker image
* Use of Helm Charts for cloud deployment

JIRA: https://issues.redhat.com/browse/WFLY-14563

Signed-off-by: Jeff Mesnil <jmesnil@redhat.com>
@jmesnil jmesnil force-pushed the WFLY-14563_todo-backend branch 2 times, most recently from b0b7f7d to 6d2327d Compare March 22, 2021 16:13
Copy link

@senatov senatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

todo-backend/README.adoc Outdated Show resolved Hide resolved
todo-backend/README.adoc Outdated Show resolved Hide resolved
todo-backend/README.adoc Outdated Show resolved Hide resolved
todo-backend/README.adoc Outdated Show resolved Hide resolved
todo-backend/README.adoc Show resolved Hide resolved
todo-backend/README.adoc Show resolved Hide resolved
todo-backend/todo-backend-bootable-jar.yaml Outdated Show resolved Hide resolved
todo-backend/todo-backend-s2i.yaml Outdated Show resolved Hide resolved
todo-backend/README.adoc Outdated Show resolved Hide resolved
todo-backend/pom.xml Outdated Show resolved Hide resolved
@jmesnil jmesnil force-pushed the WFLY-14563_todo-backend branch 2 times, most recently from 23a0609 to 644e743 Compare March 24, 2021 16:14
Fix proper use of shared attributes

JIRA: https://issues.redhat.com/browse/WFLY-14563

Signed-off-by: Jeff Mesnil <jmesnil@redhat.com>
* Move the Helm Charts file to
https://github.com/wildfly/wildfly-charts/tree/main/examples/todo-backend
* Add parameters to identy the tag of the quickstart Git repository as
  well as the version of the S2I image:
  * WildFlyQuickStartRepoTag
  * EAPQuickStartRepoTag
  * productImageVersion

Signed-off-by: Jeff Mesnil <jmesnil@redhat.com>
Copy link
Contributor

@jbliznak jbliznak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates

* add integration test (requires a managed WildFly server
  and the `arq-managed` profile to be run)

JIRA: https://issues.redhat.com/browse/WFLY-14563

Signed-off-by: Jeff Mesnil <jmesnil@redhat.com>
In the README, use a array to configure the `build.s2i.galleonLayers`
(that is possible since wildfly-charts 1.2.0).

JIRA: https://issues.redhat.com/browse/WFLY-14563

Signed-off-by: Jeff Mesnil <jmesnil@redhat.com>
* include section to run the integration tests

JIRA:  https://issues.redhat.com/browse/WFLY-14563

Signed-off-by: Jeff Mesnil <jmesnil@redhat.com>
* use the `ejb-lite` instead of the `ejb` layer to avoid pulling
  unneeded dependencies

JIRA: https://issues.redhat.com/browse/WFLY-14563

Signed-off-by: Jeff Mesnil <jmesnil@redhat.com>
* added note about get the chart's README
* added note that todobackend.com is an external service

JIRA: https://issues.redhat.com/browse/WFLY-14563

Signed-off-by: Jeff Mesnil <jmesnil@redhat.com>
* remove the `ejb-lite` layer when the server is provisioned as the
  `cloud-server` layer contains everything needed to run the
  application.

JIRA: https://issues.redhat.com/browse/WFLY-14563

Signed-off-by: Jeff Mesnil <jmesnil@redhat.com>
@emmartins emmartins merged commit e1133f8 into wildfly:master Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants