Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFLY-14827] Add an explicit FacesConfiguration class #500

Merged
merged 1 commit into from Jun 16, 2021

Conversation

fischey
Copy link

@fischey fischey commented Jun 7, 2021

This will fix https://issues.redhat.com/browse/WFLY-14827.

Currently it is necessary to either write an external Injection Point per JSF-specific injections points like @FacesContext or similiar.
Or you can use a class which is annotated with @FacesConfig which will give you the expected behaviour like in the docs.

In this PR a dedicated configuration class is used to activate JSF 2.3 features in JBoss EAP 7.3
Injection points like FacesContext and ExternalContext work out of the box in JBoss EAP 7.3 with this class.

No manual CDI Produces are necessary and JSF 2.3 works like described in the JSF docs.

…ation to enable automatic injection of JSF-specific beans like FacesContext etc.
@emmartins
Copy link
Contributor

@fischey thank you!
@fjuma can you please review?

@emmartins emmartins changed the title Fix WFLY-14827 - Add an explicit FacesConfiguration class [WFLY-14827] Add an explicit FacesConfiguration class Jun 10, 2021
Copy link
Contributor

@fjuma fjuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fischey!

@fischey
Copy link
Author

fischey commented Jun 11, 2021

You are welcome :-)

@emmartins emmartins merged commit 3d492ef into wildfly:master Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants