[WFLY-17529] enabled jaxws-retail in parent modules #654
Conversation
| @@ -39,6 +39,7 @@ | |||
| </licenses> | |||
| <properties> | |||
| <checkstyle.skip>true</checkstyle.skip> | |||
| <version.jbossws-cxf-client>6.1.0.Final</version.jbossws-cxf-client> | |||
There was a problem hiding this comment.
Perhaps we should we also add this to the JAXWS Client BOM?
There was a problem hiding this comment.
I have no objection
There was a problem hiding this comment.
There was a problem hiding this comment.
Indeed, just confirmed such artifact is a top level dependency on the JAXWS-Client BOM (see https://github.com/wildfly/boms/blob/main/client/jaxws-client/pom.xml#L100 ), so no need to manage version here
There was a problem hiding this comment.
org.jboss.ws.plugins:jaxws-tools-maven-plugin does not process wildfly-jaxws-client-bom
as the enclosing pom.xml does, thus org.jboss.ws.cxf:jbossws-cxf-client must be specified
with version in order for wsconsume to function properly. Declaring the BOM and/or
jbossws-cxf-client in a dependency block within jaxws-tools-maven-plugin does not work
either. It appears the declaration of jbossws-cxf-client must stay.
There was a problem hiding this comment.
on diff on line 50+ we see it was used like that before so did something change causing it stopped working or did we have not-working QS for years?
BTW originally switched to using wildfly-jaxws-client-bom in b43203e more than 4 years ago
| <dependency> | ||
| <groupId>org.jboss.ws.cxf</groupId> | ||
| <artifactId>jbossws-cxf-client</artifactId> | ||
| <version>${version.jbossws-cxf-client}</version> |
There was a problem hiding this comment.
provided scope or is it supposed for this dep to be packaged in the deployment?
| @@ -70,6 +77,7 @@ | |||
| <artifactId>maven-war-plugin</artifactId> | |||
| <configuration> | |||
| <attachClasses>true</attachClasses> | |||
| <packagingExcludes>WEB-INF/lib/cxf-*.jar</packagingExcludes> | |||
There was a problem hiding this comment.
I guess this is related to not using the provided scope for the new dependency?
|
@emmartins There is no conflict in assembly.xml. wfly-17529 and wfly-17528 are separate jiras. The changes in the assembly.xml is appropriate for each jira. |
|
@emmartins https://github.com/wildfly/boms.git main branch no longer builds. How to resolve? |
|
Hi @rsearls, I updated the QS repo to use WildFly 28.0.0.Beta1 BOMs and with those I tried this Quickstart without any change, following the README instructions, and build+deploy, wdsl access on browser, and executing the client all worked fine... Can you please confirm that and if all good for you too, can you please change the PR to just re-enable the QS on build and dist, similar to what was done for jaxws-ejb? |
|
@emmartins
In order to confirm your changes at minimum I should be able to rebase |
|
@rsearls all you need is to checkout current main branch of wildfly/quickstart , cd to jaxws-retail and try it with https://github.com/wildfly/wildfly/releases/download/28.0.0.Beta1/wildfly-28.0.0.Beta1.zip (no need to build BOMs or anything else) |
|
@emmartins |
No description provided.