Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFLY-17916] Disable MP Metrics and MP OpenTracing Quickstarts #660

Merged
merged 1 commit into from Apr 20, 2023

Conversation

jasondlee
Copy link
Contributor

https://issues.redhat.com/browse/WFLY-17916

Remove the entries for the two specs

@emmartins
Copy link
Contributor

@jasondlee we need to at least disable them on dist/src/main/assembly/assembly.xml
@bstansberry shouldn't we also remove the related quickstart folders?

@jasondlee
Copy link
Contributor Author

@jasondlee we need to at least disable them on dist/src/main/assembly/assembly.xml
@bstansberry shouldn't we also remove the related quickstart folders?

@emmartins, I thought I searched the project for references, but I guess I missed that one. I'll get it fixed. And, yes, I think we should remove those folder. I pinged on chat about that to sure about that first, but I'll remove them and update the PR

Remove the <module> entries for the two specs
Remove maven modules
@emmartins emmartins merged commit 523a0ce into wildfly:main Apr 20, 2023
8 checks passed
@emmartins
Copy link
Contributor

Merged, thanks.
PS: FYI there is no need to manually update the root README table of available quickstarts, such table is generated and updated automatically when doing a full project build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants