[WFLY-18503] security-domain-to-domain Quickstart Common Enhancements… #749
Conversation
|
Hi @PrarthonaPaul. Thanks for your PR. I'm waiting for a wildfly member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
PrarthonaPaul
force-pushed
the
security-domain-to-domain-enhancements
branch
3 times, most recently
from
6509aab
to
b7108c5
Compare
PrarthonaPaul
force-pushed
the
security-domain-to-domain-enhancements
branch
from
b7108c5
to
577e325
Compare
PrarthonaPaul
force-pushed
the
security-domain-to-domain-enhancements
branch
from
577e325
to
0405a6a
Compare
|
Hi @emmartins |
| </feature-packs> | ||
| <layers> | ||
| <!-- layers may be used to customize the server to provision --> | ||
| <layer>cloud-server</layer> |
There was a problem hiding this comment.
Isn't the ejb layer needed too?
There was a problem hiding this comment.
+1 it's strange to me that the tests don't fail.
There was a problem hiding this comment.
The profiles are in wrong pom.xml, this a multi module maven project.
There was a problem hiding this comment.
As a matter of fact this one is different than everything else so far, the deployment dir is the "ear" module. I wonder if we need to drop that (and instead pack the ejb in the war) to use server provisioning, will try to find time to investigate this later today.
There was a problem hiding this comment.
@PrarthonaPaul due to ^^ I may end up sending you a PR to fix everything, will let you know after investigation
There was a problem hiding this comment.
Sounds good!
Thanks, everyone for noticing it!
| pull_request: | ||
| types: [opened, synchronize, reopened, ready_for_review] | ||
| paths: | ||
| - security-domain-to-domain/**' |
There was a problem hiding this comment.
- 'security-domain-to-domain/**'
| //************************************************* | ||
| // Product Release content only | ||
| //************************************************* | ||
| ifdef::ProductRelease[] | ||
| :server_provisioning_server_host: https://localhost:8443 | ||
| include::../shared-doc/build-and-run-the-quickstart-with-provisioned-server.adoc[leveloffset=+1] |
There was a problem hiding this comment.
already included, please remove this line
| <plugin> | ||
| <groupId>org.wildfly.plugins</groupId> | ||
| <artifactId>wildfly-maven-plugin</artifactId> | ||
| <configuration> |
There was a problem hiding this comment.
packaging script is missing
| //************************************************* | ||
| // Product Release content only | ||
| //************************************************* | ||
| ifdef::ProductRelease[] | ||
| :server_provisioning_server_host: https://localhost:8443 |
There was a problem hiding this comment.
this quickstart uses standard server host for test, please remove
There was a problem hiding this comment.
Please add attribute :deploymentDir: web on line 15.
|
WFLY 31.0.0.Beta1 has been released, please rebase this PR with upstream/main branch, and update:
|
PrarthonaPaul
force-pushed
the
security-domain-to-domain-enhancements
branch
from
0405a6a
to
451f68e
Compare
PrarthonaPaul
force-pushed
the
security-domain-to-domain-enhancements
branch
from
451f68e
to
faf7f9d
Compare
|
Hi @emmartins |
|
Superseded by #887 |
… CY2023Q3
Issue: https://issues.redhat.com/browse/WFLY-18503
This QS is open shift incompatible