Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFLY-18483] Update the jaxrs-jwt for the Common Enhancements. Make t… #775

Merged
merged 1 commit into from Nov 20, 2023

Conversation

jamezp
Copy link
Member

@jamezp jamezp commented Nov 15, 2023

…his quickstart a single module and use the test for the client side example.

https://issues.redhat.com/browse/WFLY-18483

Copy link

openshift-ci bot commented Nov 15, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@jamezp
Copy link
Member Author

jamezp commented Nov 15, 2023

/test all

@jamezp
Copy link
Member Author

jamezp commented Nov 15, 2023

It looks like there is a race in the reload, which makes sense. I've filed https://issues.redhat.com/browse/WFMP-224 to address some reload cases in the plugin that should help. Once the rest of the tests run and I have a chance to test with OpenShift, I'll fix that reload.

@emmartins
Copy link
Contributor

FYI other QS did remove the reload (it doesn't make much sense for provisioning anyway), and I reported this previously at https://issues.redhat.com/browse/WFLY-18698

@jamezp
Copy link
Member Author

jamezp commented Nov 15, 2023

FYI other QS did remove the reload (it doesn't make much sense for provisioning anyway), and I reported this previously at https://issues.redhat.com/browse/WFLY-18698

It makes sense for other goals like start, dev and run though. I agree it definitely doesn't make sense for the packaging and provisioning goals though. I really think this needs to be done in the wildfly-maven-plugin which I'll likely do today.

@jamezp jamezp marked this pull request as ready for review November 16, 2023 01:45
…his quickstart a single module and use the test for the client side example.

Signed-off-by: James R. Perkins <jperkins@redhat.com>
@emmartins emmartins merged commit 630f60a into wildfly:main Nov 20, 2023
20 checks passed
@emmartins
Copy link
Contributor

thank you @jamezp

@jamezp jamezp deleted the WFLY-18483 branch November 21, 2023 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants