[WFLY-18499] mp rest-client README rework #789
Conversation
emmartins
force-pushed
the
WFLY-18499-2
branch
from
0796f24
to
78415e2
Compare
emmartins
force-pushed
the
WFLY-18499-2
branch
from
78415e2
to
3e6e35a
Compare
|
@jamezp here is the PR fixing/rework the readme, simplifying and putting content in sync with your rework, please review |
|
@emmartins Do we want to remove the scratch content? I thought it was pretty good and when I walked through it it worked for me locally? The other changes look fine. |
|
It didn’t work, and I believe this is what Yeray was reporting in the JIRA
too, cause it was missing some needed parts, but that actually wasn’t the
main reason for the rework, it was still targeting the old structure of
country server be country client, not matching your rework. Honestly
keeping up to date “from scratch” instructions have been a challenge to
maintain, and not just for this particular quickstart, but if you prefer to
keep it that way and fix the old content that’s fine. Personally I think
those are fine once, then become redundant, thus the “move” to the new app
dev doc.
…On Thu, 30 Nov 2023 at 16:41, James R. Perkins ***@***.***> wrote:
@emmartins <https://github.com/emmartins> Do we want to remove the
scratch content? I thought it was pretty good and when I walked through it
it worked for me locally?
The other changes look fine.
—
Reply to this email directly, view it on GitHub
<#789 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEDY6B7CGEHG6DP3HK47PLYHCZMVAVCNFSM6AAAAABABKJPOGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZUGEZTSMBUHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
My only argument for keeping it would be this is supposed to be a client example, and it's kind of not a client example. The test is, but I'm not sure how relevant that is. The walk through just shows how to create the actual client which is kind of the point of the quickstart. |
|
@jamezp this was just my proposal for a quick fix, it would be good to have a fix for WFLY 31 beta, pls let me know if you want to propose something else |
|
sorry, wrong button, unintentional close :-) |
|
/retest |
|
@jamezp what do you want to do with this, should I merge it and you enhance docs "later", or you will superseed this with working "from scratch" instructions? Trying to find time to work on xp5 dev branch before shutdown, would be nice to have the dev for this qs done. |
|
@emmartins It's up to you. I think they're good instructions, but if others tested and they didn't work I guess delete them. I'm not sure when I'd have time to update them TBH. I've got a lot on my plate right now. |
|
@jamezp ok I will merge this now, since it makes it read for xp5 qe, and whenever you have a chance and will feel free to rework such doc. PS: we should end up moving all those "from scratch" content and integrate in the new guide anyway |
Issue: https://issues.redhat.com/browse/WFLY-18499
Followup of #780, reworks the README: