[WFLY-15849] OpenTelemetry QS on OpenShift #872

emmartins · 2024-01-30T11:59:24Z

Clean up YAML
Add instructions for deploying otel collector on OS
OepnShift CI setup

emmartins · 2024-01-30T12:00:12Z

Superseeds #870

kabir · 2024-01-30T13:17:28Z

@emmartins For some reason the opentelemetry tests are not getting picked up. See https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/wildfly_quickstart/872/pull-ci-wildfly-quickstart-main-wildfly-quickstart-e2e/1752305685376274432/artifacts/wildfly-quickstart-e2e/quickstart-build/build-log.txt

Right at the end

Parsed test directories, and determined tests should be run for the following directories:
	
Running tests...
All tests run in 0m0s.
\033[0;32mAll tests passed!\033[0m

emmartins · 2024-01-30T13:19:01Z

AFAIK That will be fixed by another PR.

…

On Tue, 30 Jan 2024 at 13:17, Kabir Khan ***@***.***> wrote: @emmartins <https://github.com/emmartins> For some reason the opentelemetry tests are not getting picked up. See https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/wildfly_quickstart/872/pull-ci-wildfly-quickstart-main-wildfly-quickstart-e2e/1752305685376274432/artifacts/wildfly-quickstart-e2e/quickstart-build/build-log.txt Right at the end Parsed test directories, and determined tests should be run for the following directories: Running tests... All tests run in 0m0s. \033[0;32mAll tests passed!\033[0m — Reply to this email directly, view it on GitHub <#872 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAEDY6HWZCCU4FG7J4WWBOLYRDXHFAVCNFSM6AAAAABCRDS3OCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJWHAZTAMJSGE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

kabir · 2024-01-30T13:21:45Z

It might be because the GH Action workflow is called quickstart_opentelemetry_ci.yml while the quickstart folder is called opentelemetry-tracing, which would cause it to miss this check https://github.com/wildfly/quickstart/blob/main/.ci/openshift-ci/build-root/scripts/openshift-test-runner.sh#L151-L153

Either the quickstart_opentelemetry_ci.yml file needs to be called quickstart_opentelemetry-tracing_ci.yml, or the quickstart folder needs to be renamed to opentelemetry

jasondlee · 2024-01-30T13:36:48Z

Either the quickstart_opentelemetry_ci.yml file needs to be called quickstart_opentelemetry-tracing_ci.yml, or the quickstart folder needs to be renamed to opentelemetry

I can address that issue here: #871

Build with openshift profile Clean up YAML Modify how WF is configured under OS build Add instructions for deploying otel collector on OS

emmartins · 2024-01-30T14:33:49Z

It might be because the GH Action workflow is called quickstart_opentelemetry_ci.yml while the quickstart folder is called opentelemetry-tracing, which would cause it to miss this check https://github.com/wildfly/quickstart/blob/main/.ci/openshift-ci/build-root/scripts/openshift-test-runner.sh#L151-L153

Either the quickstart_opentelemetry_ci.yml file needs to be called quickstart_opentelemetry-tracing_ci.yml, or the quickstart folder needs to be renamed to opentelemetry

fixed, added functions override and remove test exclusion

jasondlee

Looks good to me. I'll close my PR in favor of this one.

kabir

I've checked the OpenShift tests, and they are running

kstekovi · 2024-02-01T09:57:50Z

The OpenShift guide have unorganized steps compare to bootabale jar.
bootable-jar:

build
start app
start integration tests
stop

OpenShift:

prerequisites (start the opentelemetry)
deploy QS
uninstall
start integration tests

emmartins · 2024-02-01T10:00:13Z

That issue of undeploy before testing affects all QS, it is something we need to address separately, please ignore on this PR.

…

On Thu, 1 Feb 2024 at 09:58, Krystof Stekovic ***@***.***> wrote: The OpenShift guide have unorganized steps compare to bootabale jar. bootable-jar: - build - start app - start integration tests - stop OpenShift: - prerequisites (start the opentelemetry) - deploy QS - uninstall - start integration tests — Reply to this email directly, view it on GitHub <#872 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAEDY6DBRVNGR5R5SLAUMH3YRNRKXAVCNFSM6AAAAABCRDS3OCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRQHE2DEOBSGY> . You are receiving this because you were mentioned.Message ID: ***@***.***>

kstekovi · 2024-02-01T10:02:11Z

.ci/openshift-ci/build-root/scripts/qs-overrides/opentelemetry-tracing/overridable-functions.sh

+
+function cleanPrerequisites() {
+  echo "Deleting all OpenTelemetry Collector resources"
+  oc delete -f charts/opentelemetry-collector.yaml


I think this step should as additional step in undeploy

The proper solution for this requires an additional extension point for shared-docs, similar to helm-install-prerequisites, and that will affect all QS so I have created https://issues.redhat.com/browse/WFLY-18986 to deliver it (and more general shared improvements). For now the uninstall is referenced as a note at https://github.com/wildfly/quickstart/pull/872/files#diff-437f0901bdbc94e992d4b6b75f355240a557c4879683f47d27dad1c51f27dc4aR19

emmartins · 2024-02-01T10:06:21Z

I did think of that, but we will need to add another extension point on the shared-docs, similar to what we have for extra pre requisites install. Due to tight schedule for now I opted for a note on the pre requisites install content, but definitely in the future I would like to add such undeploy extension point and have mp reactive, micrometer and opentelemetry QS to provide an impl for that. If you agree of course, your call, you have the right to request that now if you want :-)

…

On Thu, 1 Feb 2024 at 10:02, Krystof Stekovic ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In .ci/openshift-ci/build-root/scripts/qs-overrides/opentelemetry-tracing/overridable-functions.sh <#872 (comment)>: > @@ -0,0 +1,9 @@ +function runPostHelmInstallCommands() { + echo "Applying all OpenTelemetry Collector resources" + oc apply -f charts/opentelemetry-collector.yaml +} + +function cleanPrerequisites() { + echo "Deleting all OpenTelemetry Collector resources" + oc delete -f charts/opentelemetry-collector.yaml I think this step should as additional step in undeploy — Reply to this email directly, view it on GitHub <#872 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAEDY6ECDHVNBEZT5XFT7OTYRNR3JAVCNFSM6AAAAABCRDS3OCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQNJWGA3DSNZSHE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

kstekovi · 2024-02-01T10:13:40Z

It seem to be similar issues with steps organization. So I think this could be fixed in that scope. #872 (comment)

I did think of that, but we will need to add another extension point on the shared-docs, similar to what we have for extra pre requisites install. Due to tight schedule for now I opted for a note on the pre requisites install content, but definitely in the future I would like to add such undeploy extension point and have mp reactive, micrometer and opentelemetry QS to provide an impl for that. If you agree of course, your call, you have the right to request that now if you want :-)
…
On Thu, 1 Feb 2024 at 10:02, Krystof Stekovic @.> wrote: @.* commented on this pull request. ------------------------------ In .ci/openshift-ci/build-root/scripts/qs-overrides/opentelemetry-tracing/overridable-functions.sh <#872 (comment)>: > @@ -0,0 +1,9 @@ +function runPostHelmInstallCommands() { + echo "Applying all OpenTelemetry Collector resources" + oc apply -f charts/opentelemetry-collector.yaml +} + +function cleanPrerequisites() { + echo "Deleting all OpenTelemetry Collector resources" + oc delete -f charts/opentelemetry-collector.yaml I think this step should as additional step in undeploy — Reply to this email directly, view it on GitHub <#872 (review)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEDY6ECDHVNBEZT5XFT7OTYRNR3JAVCNFSM6AAAAABCRDS3OCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQNJWGA3DSNZSHE . You are receiving this because you were mentioned.Message ID: @.***>

emmartins · 2024-02-01T10:49:37Z

The OpenShift guide have unorganized steps compare to bootabale jar. bootable-jar:

build

start app

start integration tests

stop

OpenShift:

prerequisites (start the opentelemetry)

deploy QS

uninstall

start integration tests

fixed

kstekovi · 2024-02-01T11:27:33Z

OpenShift steps works as is expected. Ready to merge. Thanks.

emmartins · 2024-02-01T11:32:41Z

thank you @kstekovi

emmartins mentioned this pull request Jan 30, 2024

[WFLY-18943] Fix automated testing of OpenTelemetry QS under OpenShift #870

Closed

emmartins force-pushed the WFLY-18943 branch 2 times, most recently from 625c1f1 to 9c8c1b0 Compare January 30, 2024 12:19

jasondlee approved these changes Jan 30, 2024

View reviewed changes

[WFLY-18943] Fix automated testing of OpenTelemetry QS under OpenShift

0f51653

Build with openshift profile Clean up YAML Modify how WF is configured under OS build Add instructions for deploying otel collector on OS

emmartins force-pushed the WFLY-18943 branch from 9c8c1b0 to 0f51653 Compare January 30, 2024 14:30

jasondlee approved these changes Jan 30, 2024

View reviewed changes

kabir approved these changes Jan 30, 2024

View reviewed changes

emmartins changed the title ~~[WFLY-15849] OpenTelemetry QS under OpenShift~~ [WFLY-15849] OpenTelemetry QS on OpenShift Jan 30, 2024

jasondlee mentioned this pull request Jan 30, 2024

[WFLY-18974] - Re-enable OS testing for micrometer and otel QSs #871

Closed

kstekovi reviewed Feb 1, 2024

View reviewed changes

Fixing order of openshift instructions undeploy and testing

1dd3780

kstekovi approved these changes Feb 1, 2024

View reviewed changes

emmartins merged commit 9dcbe39 into wildfly:main Feb 1, 2024
20 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WFLY-15849] OpenTelemetry QS on OpenShift #872

[WFLY-15849] OpenTelemetry QS on OpenShift #872

emmartins commented Jan 30, 2024 •

edited

emmartins commented Jan 30, 2024

kabir commented Jan 30, 2024

emmartins commented Jan 30, 2024 via email

kabir commented Jan 30, 2024

jasondlee commented Jan 30, 2024

emmartins commented Jan 30, 2024

jasondlee left a comment

kabir left a comment

kstekovi commented Feb 1, 2024

emmartins commented Feb 1, 2024 via email

kstekovi Feb 1, 2024

emmartins Feb 1, 2024

emmartins commented Feb 1, 2024 via email

kstekovi commented Feb 1, 2024

emmartins commented Feb 1, 2024

kstekovi commented Feb 1, 2024

emmartins commented Feb 1, 2024

[WFLY-15849] OpenTelemetry QS on OpenShift #872

[WFLY-15849] OpenTelemetry QS on OpenShift #872

Conversation

emmartins commented Jan 30, 2024 • edited

emmartins commented Jan 30, 2024

kabir commented Jan 30, 2024

emmartins commented Jan 30, 2024 via email

kabir commented Jan 30, 2024

jasondlee commented Jan 30, 2024

emmartins commented Jan 30, 2024

jasondlee left a comment

Choose a reason for hiding this comment

kabir left a comment

Choose a reason for hiding this comment

kstekovi commented Feb 1, 2024

emmartins commented Feb 1, 2024 via email

kstekovi Feb 1, 2024

Choose a reason for hiding this comment

emmartins Feb 1, 2024

Choose a reason for hiding this comment

emmartins commented Feb 1, 2024 via email

kstekovi commented Feb 1, 2024

emmartins commented Feb 1, 2024

kstekovi commented Feb 1, 2024

emmartins commented Feb 1, 2024

emmartins commented Jan 30, 2024 •

edited