Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFLY-18476] Additional fixes/enhancements #885

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

emmartins
Copy link
Contributor

Issue: https://issues.redhat.com/browse/WFLY-18476
Changes:

  • Moves README.adoc to README-source.adoc
  • Moves section set_up_client_keystore_using_java_keytool to after the server is started
  • Adds extraStandardDistTestParams and extraProvisioningTestParams extension points to add extra testing params
  • Removes include for outdated sections wrt IDEs and debug
  • Syncs pom version properties
  • Moves http-client dependency to manged version, and test scope
  • Simplifies basic test usage of a server.dir property

@PrarthonaPaul
Copy link
Contributor

PrarthonaPaul commented Mar 25, 2024

Hi @emmartins
Thanks for adding the changes.
I think they look good.
One note: for the tests, we need to specify the server home using -Djboss.server.config.dir=PATH/TO/WIDFLY/HOME/standalone/configuration so the certificates can be found by the test. This is also the case when running the tests using a provisioned server.

@emmartins emmartins merged commit 6188717 into wildfly:main Mar 25, 2024
20 checks passed
@emmartins
Copy link
Contributor Author

Thanks @PrarthonaPaul , please note that I did change that a bit too, the property was renamed to "server.dir", and it should point only to the server base dir, the test than joins the "standalone/configuration" path to it. Also, it defaults to target/server, so no param is needed when testing server provisioning.

The doc rebuilt is now complete and you now have this server.dir param in the standard server dist testing command (see https://github.com/wildfly/quickstart/tree/main/helloworld-mutual-ssl)

@PrarthonaPaul
Copy link
Contributor

Thanks @PrarthonaPaul , please note that I did change that a bit too, the property was renamed to "server.dir", and it should point only to the server base dir, the test than joins the "standalone/configuration" path to it. Also, it defaults to target/server, so no param is needed when testing server provisioning.

The doc rebuilt is now complete and you now have this server.dir param in the standard server dist testing command (see https://github.com/wildfly/quickstart/tree/main/helloworld-mutual-ssl)

That sounds good!
I was thinking the same too while adding the comment. Thank you for making the edits!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants