Upgrade to wildfly CR2, re-add embedded, remove common-core dep #18
Conversation
|
👍 embedded container works great |
| @@ -90,7 +91,7 @@ | |||
| <dependency> | |||
| <groupId>org.jboss.sasl</groupId> | |||
| <artifactId>jboss-sasl</artifactId> | |||
| </dependency> | |||
| </dependency>--> | |||
There was a problem hiding this comment.
If they aren't needed, let's delete.
There was a problem hiding this comment.
ah i missed that, let me push update
|
The provisioning stuff shouldn't be needed. We should be able to just remove the |
|
wdym @jamezp I did remove org.wildfly.core:wildfly-core-feature-pack dependancies. |
|
This should use core 1.0.0.CR2 once it's out on Friday. Then https://github.com/wildfly/wildfly-arquillian/blob/master/container-embedded/src/main/java/org/jboss/as/arquillian/container/embedded/EmbeddedDeployableContainer.java#L47 will need to be changed to not pass in a bundlePath param. |
|
@bstansberry I don't mind waiting till friday, but we should do release of this right after CR2 is out, so we can get it also to WildFly full. |
|
@ctomc I don't think we need the provisioning either. I don't see any reason either the feature-pack or provisioning stuff is needed. Unless I'm missing something. |
ctomc
changed the title
Upgrade to wildfly CR2, re-add embedded, remove common-core dep
|
Thanks guys! |
Also change the way we do testing with usage of provisioning plugin & feature-packs
should address https://issues.jboss.org/browse/WFLY-4572