[WFARQ-14] Introduce sanity check for container deployment count. #84
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://issues.jboss.org/browse/WFARQ-14
ServerSetupObserver depends on the fact that for every call to deploy there is a corresponding call to undeploy, which means that that the deployment count for a container is zero or greater and will eventally return to zero by the end of a test. When the deployment count for a container goes below zero (for example, if deployments are manually controlled and the deployment logic is flawed), this can cause the entirely of the logic of ServerSetupObserver to break, and the incorrect state can get propagated across test cases in a test suite, making tracking down the error hard.
This issue adds a sanity check on container deployment counts which throws a RuntimeException if the count becomes negative.