Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFARQ-14] Introduce sanity check for container deployment count. #84

Closed
wants to merge 1 commit into from

Conversation

rachmatowicz
Copy link

@rachmatowicz rachmatowicz commented Nov 23, 2016

See https://issues.jboss.org/browse/WFARQ-14

ServerSetupObserver depends on the fact that for every call to deploy there is a corresponding call to undeploy, which means that that the deployment count for a container is zero or greater and will eventally return to zero by the end of a test. When the deployment count for a container goes below zero (for example, if deployments are manually controlled and the deployment logic is flawed), this can cause the entirely of the logic of ServerSetupObserver to break, and the incorrect state can get propagated across test cases in a test suite, making tracking down the error hard.

This issue adds a sanity check on container deployment counts which throws a RuntimeException if the count becomes negative.

Copy link
Member

@rhusar rhusar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Richard this doesn't seem right actually.

Please see my fix I just submitted and comments on it: #85

@jamezp
Copy link
Member

jamezp commented Dec 16, 2016

Closing this in favor of #85

@jamezp jamezp closed this Dec 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants