Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WFARQ-14 NPE in ServerSetupObserver.handleAfterUndeploy #85

Merged
merged 1 commit into from
Dec 16, 2016
Merged

WFARQ-14 NPE in ServerSetupObserver.handleAfterUndeploy #85

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 7 additions & 1 deletion common/src/main/java/org/jboss/as/arquillian/container/ServerSetupObserver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,13 @@ public synchronized void handleAfterUndeploy(@Observes AfterUnDeploy afterDeploy
if(deployed == null) {
return;
}
int count = deployed.get(container.getName());
Integer count = deployed.get(container.getName());
if (count == null) {
// The deployment was already undeployed or never deployed
// AfterUnDeploy and BeforeUnDeploy events are fired by arquillian-core regardless of deployment status
log.debugf("No deployments found for container %s.", container.getName());
return;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about adding some debug logging here just to indicate the container appears to have been removed and is being skipped?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am hoping this won't be necessary if we can nail down the real cause (somewhere along the lines of #86 is attempting).

}
deployed.put(container.getName(), --count);
if (count == 0 && afterClassRun) {
for (int i = setupTasksInForce.size() - 1; i >= 0; i--) {
Expand Down