New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix problems revealed when domain testsuite runs with assertions enabled. #1086
Conversation
b3fb562
to
cb043ec
Compare
Core - Full Integration Build 1866 outcome was FAILURE using a merge of cb043ec Failed tests
|
Full integration - Windows Build 288 outcome was FAILURE using a merge of cb043ec Failed tests
|
Linux Build 2755 outcome was FAILURE using a merge of cb043ec |
Core - Full Integration Build 1867 outcome was FAILURE using a merge of cb043ec Failed tests
|
Full integration - Windows Build 289 outcome was FAILURE using a merge of cb043ec Failed tests
|
Linux Build 2756 outcome was FAILURE using a merge of cb043ec |
cb043ec
to
3bf3913
Compare
Core - Full Integration Build 1871 outcome was FAILURE using a merge of 3bf3913 Failed tests
|
Full integration - Windows Build 293 outcome was FAILURE using a merge of 3bf3913 Failed tests
|
Linux Build 2760 outcome was FAILURE using a merge of 3bf3913 |
The WildFly full mixed domain tests are failing because they are running with assertions enabled. I don't see why this PR causes that though. The core problem on Linux though is presumably related. I've seen intermittent hangs of OperationCancellationTestCase. If it's happening reproducibly that's actually kind of good. |
retest this please |
Core - Full Integration Build 1874 outcome was FAILURE using a merge of 3bf3913 Failed tests
|
Full integration - Windows Build 296 outcome was FAILURE using a merge of 3bf3913 Failed tests
|
Linux Build 2763 outcome was FAILURE using a merge of 3bf3913 |
Windows Build 2257 outcome was FAILURE using a merge of 3bf3913 |
retest this please |
Full integration - Windows Build 297 outcome was FAILURE using a merge of 3bf3913 Failed tests
|
Core - Full Integration Build 1875 outcome was FAILURE using a merge of 3bf3913 Failed tests
|
Windows Build 2258 outcome was FAILURE using a merge of 3bf3913 |
retest this please |
Full integration - Windows Build 310 outcome was FAILURE using a merge of 3bf3913 Failed tests
|
Core - Full Integration Build 1888 outcome was FAILURE using a merge of 3bf3913 Failed tests
|
Linux Build 2778 outcome was FAILURE using a merge of 3bf3913 |
Windows Build 2271 outcome was FAILURE using a merge of 3bf3913 |
Windows Build 2274 outcome was FAILURE using a merge of 3bf3913 |
Linux Build 2781 outcome was FAILURE using a merge of 3bf3913 |
3bf3913
to
dc233e0
Compare
Full integration - Windows Build 314 outcome was FAILURE using a merge of dc233e0 Failed tests
|
Core - Full Integration Build 2114 outcome was FAILURE using a merge of 0426234 Failed tests
|
retest this please |
Full integration - Windows Build 557 outcome was FAILURE using a merge of 0426234 Failed tests
|
retest this please |
1 similar comment
retest this please |
0426234
to
21a0d68
Compare
retest this please |
Linux Build 3069 outcome was FAILURE using a merge of 21a0d68 Failed tests
|
… they may be run in a different thread. Also, cache the resource model used by Stage.DOMAIN transformers so we don't have to read/clone it multiple times per request. This may be critical for perf in larger domains. Also, lots of javadoc improvements
…remote side has cancelled Don't use the ProxyOperationControl interface for response processing on the target process. The interface semantics are different from what the target-side response processing does.
… until it is functional
…tContext before sending a response
…l COMPLETE_TX_REQUEST arrives
…lso avoid sending them
21a0d68
to
2cb5341
Compare
Full integration - Windows Build 594 outcome was FAILURE using a merge of 2cb5341 Failed tests
|
Fix problems revealed when domain testsuite runs with assertions enabled.
This PR does two main things:
We can skip part 1) for now if it's considered too risky for CR2. But I wanted it on for now to get CI tests of this work with assertions now. I can back out those commits before merging if that's the decision.
The details on 2) are:
a) Fix WFCORE-988
b) Fix WFCORE-989
c) Fix an issue where in some situations request tracking wasn't recording that an operation had been 'prepared' even though it had, plus some related code cleanup to help make the intended behavior clearer.