[WFCORE-57] : Deprecated resource is present in r-r-d of /subsystem=security/security-domain=* #118
Conversation
| if (registredNames != null && !registredNames.isEmpty()) { | ||
| for (String value : registredNames) { | ||
| ImmutableManagementResourceRegistration childRegistration = registry.getSubModel(PathAddress.pathAddress(PathElement.pathElement(key, value))); | ||
| isAlias = isAlias && childRegistration != null && childRegistration.isAlias(); |
There was a problem hiding this comment.
Assume this is a "singleton" fka "squatter" situation (see [1])...
Then wildCardChildRegistration will be null, so from L220 isAlias will be false, so the result of L225 will always be false.
This means a singleton/squatter could never be processed as an alias. But such a registration could be an alias.
Are lines 219-200 needed? Can declaring isAlias = true to start and then setting to false and breaking the loop if childRegistration.isAlias() work?
[1] http://lists.jboss.org/pipermail/wildfly-dev/2014-August/002701.html
| @@ -817,7 +858,7 @@ public void execute(OperationContext context, ModelNode operation) throws Operat | |||
|
|
|||
| public static AccessControl forName(String localName) { | |||
| final AccessControl value = localName != null ? MAP.get(localName.toLowerCase()) : null; | |||
| return value == null ? AccessControl.valueOf(localName.toUpperCase(Locale.ENGLISH)) : value; | |||
| return value == null ? AccessControl.valueOf(localName.toUpperCase()) : value; | |||
There was a problem hiding this comment.
Is there a reason we're removing the locale? It seems it should be left there.
There was a problem hiding this comment.
No reason, or no we shouldn't leave it there?
Because we should leave it there.
There was a problem hiding this comment.
No reason, I'm going to add it back
…ecurity/security-domain=* Aliases were displayed without their description even if include-aliases is not set to true. Now the operations 'read-resource-description' and 'read-children-types' won't display aliases per default. Trying to take "squatter" resource into account for alias.
[WFCORE-57] : Deprecated resource is present in r-r-d of /subsystem=security/security-domain=*
JBEAP-1703 Standalone powershell script does't support SECMGR=true
Aliases were displayed without their description even if include-aliases is not set to true.
Now the operations 'read-resource-description' and 'read-children-types' won't display aliases per default.
Jira: https://issues.jboss.org/browse/WFCORE-57