WFCORE-1592, fix persisting removed entries in PropertiesFileLoader #1710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luck3y
force-pushed
the
WFCORE-1592
branch
2 times, most recently
from
88d2bf9
to
860b7cb
Compare
| PropertiesFileLoader loader2 = new PropertiesFileLoader(tmpFile.getAbsolutePath(), null); | ||
| loader2.start(null); | ||
| Properties props2 = loader2.getProperties(); | ||
| verifyProperties(props2, props2.size()-1, "NEW", "VALUE"); |
There was a problem hiding this comment.
This call doesn't validate that NEW is present with a value of VALUE, since that's not an entry in the "properties" array. You could pass null for both params and get the same effect.
Kind of a nit; it just confused me a bit.
There was a problem hiding this comment.
That's not a nit, that's me being an idiot! I refactored that into a shared method at the end to remove some duplicate code ;)
I'll send up a fix.
|
@luck3y looks good. Can you squash this one and then up a variant against 2.x? This sounds like a serious enough one to justify getting it sorted in 10.1. |
|
Sure, will send that shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.