[WFCORE-124] Convert the acceptable responses to lower case so comparision matches conversion of user input. #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -38,6 +38,11 @@ | |||
| */ | |||
| public class ConfirmationChoice implements State { | |||
|
|
|||
| private static final String LONG_YES = DomainManagementLogger.ROOT_LOGGER.yes().toLowerCase(); | |||
There was a problem hiding this comment.
If you mean to use the default locale, make that explicit here via toLowerCase(Locale.getDefault()); otherwise someone will randomly come along and make it Locale.ENGLISH, causing weird failures in some locales.
…ision matches conversion of user input.
bstansberry
added
the
ready-for-merge
bstansberry
added a commit
that referenced
this pull request
Sep 25, 2014
[WFCORE-124] Convert the acceptable responses to lower case so comparision matches conversion of user input.
iweiss
pushed a commit
to iweiss/wildfly-core
that referenced
this pull request
Jun 6, 2016
[i18n] Updated translations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.