[WFCORE-1157] listener API for process state changes #1981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehsavoie
force-pushed
the
WFCORE-1157
branch
from
d905253
to
680079f
Compare
kabir
reviewed
Nov 24, 2016
|
|
||
| @Override | ||
| protected boolean requiresRuntime(OperationContext context) { | ||
| return super.requiresRuntime(context) || context.getRunningMode() == RunningMode.ADMIN_ONLY; |
There was a problem hiding this comment.
I think will return true for:
- For a normal server - ok
- For an admin-only server -not ok
- For a HC subsystem in normal mode - ok
- For a HC subsystem in admin-only mode - ok
- For a
<profile>s subsystem in admin-only mode - NOT OK
It will return false for a <profile>s subsystem in normal mode, which is ok
There was a problem hiding this comment.
Probably just return true
- if processType.isServer()
- Otherwise, check that the address begins with the 'host' and 'subsystem' keys
|
|
||
| @Override | ||
| protected boolean requiresRuntime(OperationContext context) { | ||
| return super.requiresRuntime(context) || context.getRunningMode() == RunningMode.ADMIN_ONLY; |
There was a problem hiding this comment.
This will return true for a s subsystem in admin-only mode - NOT OK
| * This should not throw an exception. | ||
| * @param properties the properties to initialize the listener. | ||
| */ | ||
| default void init(Map<String, String> properties) {} |
There was a problem hiding this comment.
One point Brian made was that
- Does ProcessStateListener.init provide adequate information to allow callers to decide what to do? (ProcessType, RunningMode, current RuntimeConfigurationState, current RunningState)
Also, if ProcessType, RunningMode are provided via init there is no need to provide them with the event objects as they do not change.
There was a problem hiding this comment.
If we do this, we should make sure that we wrap this in a class (ProcessStateListenerInitEvent or something like that) so that we can extend it with more information in future
|
ModuleOpsCompletionTestCase Also fails for my (#1982) PR https://ci.wildfly.org/viewLog.html?buildId=34724&buildTypeId=WildFlyCore_PullRequestWindows |
ehsavoie
force-pushed
the
WFCORE-1157
branch
10 times, most recently
from
5a31ac7
to
5325da5
Compare
|
Linux Build 4953 outcome was FAILURE using a merge of de07c29 Failed tests |
|
Linux Build 4955 outcome was FAILURE using a merge of de07c29 Failed tests |
|
Linux Build 4956 outcome was FAILURE using a merge of de07c29 Failed tests |
|
Linux Build 4957 outcome was FAILURE using a merge of de07c29 Failed tests |
|
Windows Build 4273 outcome was FAILURE using a merge of de07c29 Failed tests |
ehsavoie
force-pushed
the
WFCORE-1157
branch
from
de07c29
to
4fde352
Compare
|
Windows Build 4284 outcome was FAILURE using a merge of 4fde352 Failed tests |
* add API to let user be notified of process state changes by adding a class to the resource process-state-listeners in the core-management subsystem. * add by default the core-management subsystems to the standalone and domain subsystem templates. * split the core-management module in 2 parts : client and subsystem. * one service per listener * add a specific JMX notifier that listens on RuntimeConfigurationState and RunningState changes : RunningStateJmx. * basic documentation. * small fix for ModuleOpsCompletionTestCase JIRA: https://issues.jboss.org/browse/WFCORE-1157
ehsavoie
force-pushed
the
WFCORE-1157
branch
from
4fde352
to
9cf722d
Compare
|
Full integration - Windows Build 2355 outcome was FAILURE using a merge of 9cf722d Failed tests |
|
retest this please |
|
Linux Build 4975 outcome was FAILURE using a merge of 9cf722d |
|
Linux Build 4976 outcome was FAILURE using a merge of 9cf722d |
|
Linux Build 4978 outcome was FAILURE using a merge of 9cf722d |
|
Full integration - Windows Build 2357 outcome was FAILURE using a merge of 9cf722d Failed tests |
|
Full integration - Windows Build 2361 outcome was FAILURE using a merge of 9cf722d Failed tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
class to the resource process-state-listeners in the core-management subsystem.
domain subsystem templates.
JIRA: https://issues.jboss.org/browse/WFCORE-1157
EAP: https://issues.jboss.org/browse/JBEAP-7201