WFCORE-14 - add operations for manipulating list & map attributes #206

ctomc · 2014-09-29T15:37:18Z

initial version, i want do do some more cleanup of apis for easier manipulating on side of write/read attribute handlers

wildfly-ci · 2014-09-29T15:40:12Z

Linux Build 487 is now running using a merge of e147eb8

wildfly-ci · 2014-09-29T15:40:12Z

Windows Build 232 is now running using a merge of e147eb8

wildfly-ci · 2014-09-29T15:53:30Z

Windows Build 232 outcome was FAILURE using a merge of e147eb8
Summary: Tests failed: 10 (10 new), passed: 2590, ignored: 56 Build time: 0:13:19

Build problems:

Failed tests detected

Failed tests

org.jboss.as.controller.access.rbac.ReadOperationNamesRbacTestCase.testReadOperationNamesAsAdministratorSensitiveAddressableResource: java.lang.AssertionError: [map-clear, list-clear, map-put, list-get, map-get, list-remove, list-add, map-remove]
    at org.junit.Assert.fail(Assert.java:88)
    at org.junit.Assert.assertTrue(Assert.java:41)

org.jboss.as.controller.access.rbac.ReadOperationNamesRbacTestCase.testReadOperationNamesAsMonitorNonSensitiveResource: java.lang.AssertionError: [map-clear, list-clear, map-put, list-get, map-get, list-remove, list-add, map-remove]
    at org.junit.Assert.fail(Assert.java:88)
    at org.junit.Assert.assertTrue(Assert.java:41)

org.jboss.as.controller.access.rbac.ReadOperationNamesRbacTestCase.testReadOperationNamesAsAdminstratorNonSensitiveResource: java.lang.AssertionError: [map-clear, list-clear, map-put, list-get, map-get, list-remove, list-add, map-remove]
    at org.junit.Assert.fail(Assert.java:88)
    at org.junit.Assert.assertTrue(Assert.java:41)

org.jboss.as.controller.access.rbac.ReadOperationNamesRbacTestCase.testReadOperationNamesAsMaintainerNonSensitiveResource: java.lang.AssertionError: [map-clear, list-clear, map-put, list-get, map-get, list-remove, list-add, map-remove]
    at org.junit.Assert.fail(Assert.java:88)
    at org.junit.Assert.assertTrue(Assert.java:41)

org.jboss.as.controller.test.GlobalOperationsAliasesTestCase.testRecursiveReadResourceDescriptionWithOperationsOperation: java.lang.AssertionError: expected:<12> but was:<20>
    at org.junit.Assert.fail(Assert.java:88)
    at org.junit.Assert.failNotEquals(Assert.java:743)

org.jboss.as.controller.test.GlobalOperationsAliasesTestCase.testReadResourceDescriptionWithOperationsOperation: java.lang.AssertionError: expected:<12> but was:<20>
    at org.junit.Assert.fail(Assert.java:88)
    at org.junit.Assert.failNotEquals(Assert.java:743)

org.jboss.as.controller.test.GlobalOperationsTestCase.testRecursiveReadResourceDescriptionWithOperationsOperation: java.lang.AssertionError: expected:<12> but was:<20>
    at org.junit.Assert.fail(Assert.java:88)
    at org.junit.Assert.failNotEquals(Assert.java:743)

org.jboss.as.controller.test.GlobalOperationsTestCase.testReadOperationNamesOperation: java.lang.AssertionError: expected:<12> but was:<20>
    at org.junit.Assert.fail(Assert.java:88)
    at org.junit.Assert.failNotEquals(Assert.java:743)

org.jboss.as.controller.test.GlobalOperationsTestCase.testReadResourceDescriptionWithOperationsOperation: java.lang.AssertionError: expected:<12> but was:<20>
    at org.junit.Assert.fail(Assert.java:88)
    at org.junit.Assert.failNotEquals(Assert.java:743)

org.jboss.as.controller.test.RemoteChannelProxyControllerTestCase.testReadOperationNames: java.lang.AssertionError: expected:<11> but was:<19>
    at org.junit.Assert.fail(Assert.java:88)
    at org.junit.Assert.failNotEquals(Assert.java:743)

wildfly-ci · 2014-09-29T15:56:26Z

Linux Build 487 outcome was FAILURE using a merge of e147eb8
Summary: Tests failed: 10 (10 new), passed: 2590, ignored: 56 Build time: 0:16:15

Build problems:

Failed tests detected

Failed tests

org.jboss.as.controller.access.rbac.ReadOperationNamesRbacTestCase.testReadOperationNamesAsAdministratorSensitiveAddressableResource: java.lang.AssertionError: [map-clear, list-clear, map-put, list-get, map-get, list-remove, list-add, map-remove]
    at org.junit.Assert.fail(Assert.java:88)
    at org.junit.Assert.assertTrue(Assert.java:41)

org.jboss.as.controller.access.rbac.ReadOperationNamesRbacTestCase.testReadOperationNamesAsMonitorNonSensitiveResource: java.lang.AssertionError: [map-clear, list-clear, map-put, list-get, map-get, list-remove, list-add, map-remove]
    at org.junit.Assert.fail(Assert.java:88)
    at org.junit.Assert.assertTrue(Assert.java:41)

org.jboss.as.controller.access.rbac.ReadOperationNamesRbacTestCase.testReadOperationNamesAsAdminstratorNonSensitiveResource: java.lang.AssertionError: [map-clear, list-clear, map-put, list-get, map-get, list-remove, list-add, map-remove]
    at org.junit.Assert.fail(Assert.java:88)
    at org.junit.Assert.assertTrue(Assert.java:41)

org.jboss.as.controller.access.rbac.ReadOperationNamesRbacTestCase.testReadOperationNamesAsMaintainerNonSensitiveResource: java.lang.AssertionError: [map-clear, list-clear, map-put, list-get, map-get, list-remove, list-add, map-remove]
    at org.junit.Assert.fail(Assert.java:88)
    at org.junit.Assert.assertTrue(Assert.java:41)

org.jboss.as.controller.test.GlobalOperationsAliasesTestCase.testRecursiveReadResourceDescriptionWithOperationsOperation: java.lang.AssertionError: expected:<12> but was:<20>
    at org.junit.Assert.fail(Assert.java:88)
    at org.junit.Assert.failNotEquals(Assert.java:743)

org.jboss.as.controller.test.GlobalOperationsAliasesTestCase.testReadResourceDescriptionWithOperationsOperation: java.lang.AssertionError: expected:<12> but was:<20>
    at org.junit.Assert.fail(Assert.java:88)
    at org.junit.Assert.failNotEquals(Assert.java:743)

org.jboss.as.controller.test.RemoteChannelProxyControllerTestCase.testReadOperationNames: java.lang.AssertionError: expected:<11> but was:<19>
    at org.junit.Assert.fail(Assert.java:88)
    at org.junit.Assert.failNotEquals(Assert.java:743)

org.jboss.as.controller.test.GlobalOperationsTestCase.testRecursiveReadResourceDescriptionWithOperationsOperation: java.lang.AssertionError: expected:<12> but was:<20>
    at org.junit.Assert.fail(Assert.java:88)
    at org.junit.Assert.failNotEquals(Assert.java:743)

org.jboss.as.controller.test.GlobalOperationsTestCase.testReadOperationNamesOperation: java.lang.AssertionError: expected:<12> but was:<20>
    at org.junit.Assert.fail(Assert.java:88)
    at org.junit.Assert.failNotEquals(Assert.java:743)

org.jboss.as.controller.test.GlobalOperationsTestCase.testReadResourceDescriptionWithOperationsOperation: java.lang.AssertionError: expected:<12> but was:<20>
    at org.junit.Assert.fail(Assert.java:88)
    at org.junit.Assert.failNotEquals(Assert.java:743)

wildfly-ci · 2014-09-29T16:00:12Z

Windows Build 233 is now running using a merge of e147eb8

wildfly-ci · 2014-09-29T16:00:12Z

Linux Build 488 is now running using a merge of e147eb8

wildfly-ci · 2014-09-29T16:16:19Z

Linux Build 488 outcome was FAILURE using a merge of e147eb8
Summary: Tests failed: 10, passed: 2590, ignored: 56 Build time: 0:16:08

Build problems:

Failed tests detected

Failed tests

org.jboss.as.controller.access.rbac.ReadOperationNamesRbacTestCase.testReadOperationNamesAsAdministratorSensitiveAddressableResource: java.lang.AssertionError: [map-clear, list-clear, map-put, list-get, map-get, list-remove, list-add, map-remove]
    at org.junit.Assert.fail(Assert.java:88)
    at org.junit.Assert.assertTrue(Assert.java:41)

org.jboss.as.controller.access.rbac.ReadOperationNamesRbacTestCase.testReadOperationNamesAsMonitorNonSensitiveResource: java.lang.AssertionError: [map-clear, list-clear, map-put, list-get, map-get, list-remove, list-add, map-remove]
    at org.junit.Assert.fail(Assert.java:88)
    at org.junit.Assert.assertTrue(Assert.java:41)

org.jboss.as.controller.access.rbac.ReadOperationNamesRbacTestCase.testReadOperationNamesAsAdminstratorNonSensitiveResource: java.lang.AssertionError: [map-clear, list-clear, map-put, list-get, map-get, list-remove, list-add, map-remove]
    at org.junit.Assert.fail(Assert.java:88)
    at org.junit.Assert.assertTrue(Assert.java:41)

org.jboss.as.controller.access.rbac.ReadOperationNamesRbacTestCase.testReadOperationNamesAsMaintainerNonSensitiveResource: java.lang.AssertionError: [map-clear, list-clear, map-put, list-get, map-get, list-remove, list-add, map-remove]
    at org.junit.Assert.fail(Assert.java:88)
    at org.junit.Assert.assertTrue(Assert.java:41)

org.jboss.as.controller.test.GlobalOperationsAliasesTestCase.testRecursiveReadResourceDescriptionWithOperationsOperation: java.lang.AssertionError: expected:<12> but was:<20>
    at org.junit.Assert.fail(Assert.java:88)
    at org.junit.Assert.failNotEquals(Assert.java:743)

org.jboss.as.controller.test.GlobalOperationsAliasesTestCase.testReadResourceDescriptionWithOperationsOperation: java.lang.AssertionError: expected:<12> but was:<20>
    at org.junit.Assert.fail(Assert.java:88)
    at org.junit.Assert.failNotEquals(Assert.java:743)

org.jboss.as.controller.test.GlobalOperationsTestCase.testRecursiveReadResourceDescriptionWithOperationsOperation: java.lang.AssertionError: expected:<12> but was:<20>
    at org.junit.Assert.fail(Assert.java:88)
    at org.junit.Assert.failNotEquals(Assert.java:743)

org.jboss.as.controller.test.GlobalOperationsTestCase.testReadOperationNamesOperation: java.lang.AssertionError: expected:<12> but was:<20>
    at org.junit.Assert.fail(Assert.java:88)
    at org.junit.Assert.failNotEquals(Assert.java:743)

org.jboss.as.controller.test.GlobalOperationsTestCase.testReadResourceDescriptionWithOperationsOperation: java.lang.AssertionError: expected:<12> but was:<20>
    at org.junit.Assert.fail(Assert.java:88)
    at org.junit.Assert.failNotEquals(Assert.java:743)

org.jboss.as.controller.test.RemoteChannelProxyControllerTestCase.testReadOperationNames: java.lang.AssertionError: expected:<11> but was:<19>
    at org.junit.Assert.fail(Assert.java:88)
    at org.junit.Assert.failNotEquals(Assert.java:743)

wildfly-ci · 2014-09-29T16:30:20Z

Windows Build 233 outcome was FAILURE using a merge of e147eb8
Summary: Execution timeout (new); tests failed: 10, passed: 2318, ignored: 43; org.wildfly.core:wildfly-core-testsuite-domain Build time: 0:30:09

Build problems:

Failed tests detected
Execution timeout
Process exited with code 1

Failed tests

org.jboss.as.controller.access.rbac.ReadOperationNamesRbacTestCase.testReadOperationNamesAsAdministratorSensitiveAddressableResource: java.lang.AssertionError: [map-clear, list-clear, map-put, list-get, map-get, list-remove, list-add, map-remove]
    at org.junit.Assert.fail(Assert.java:88)
    at org.junit.Assert.assertTrue(Assert.java:41)

org.jboss.as.controller.access.rbac.ReadOperationNamesRbacTestCase.testReadOperationNamesAsMonitorNonSensitiveResource: java.lang.AssertionError: [map-clear, list-clear, map-put, list-get, map-get, list-remove, list-add, map-remove]
    at org.junit.Assert.fail(Assert.java:88)
    at org.junit.Assert.assertTrue(Assert.java:41)

org.jboss.as.controller.access.rbac.ReadOperationNamesRbacTestCase.testReadOperationNamesAsAdminstratorNonSensitiveResource: java.lang.AssertionError: [map-clear, list-clear, map-put, list-get, map-get, list-remove, list-add, map-remove]
    at org.junit.Assert.fail(Assert.java:88)
    at org.junit.Assert.assertTrue(Assert.java:41)

org.jboss.as.controller.access.rbac.ReadOperationNamesRbacTestCase.testReadOperationNamesAsMaintainerNonSensitiveResource: java.lang.AssertionError: [map-clear, list-clear, map-put, list-get, map-get, list-remove, list-add, map-remove]
    at org.junit.Assert.fail(Assert.java:88)
    at org.junit.Assert.assertTrue(Assert.java:41)

org.jboss.as.controller.test.GlobalOperationsAliasesTestCase.testRecursiveReadResourceDescriptionWithOperationsOperation: java.lang.AssertionError: expected:<12> but was:<20>
    at org.junit.Assert.fail(Assert.java:88)
    at org.junit.Assert.failNotEquals(Assert.java:743)

org.jboss.as.controller.test.GlobalOperationsAliasesTestCase.testReadResourceDescriptionWithOperationsOperation: java.lang.AssertionError: expected:<12> but was:<20>
    at org.junit.Assert.fail(Assert.java:88)
    at org.junit.Assert.failNotEquals(Assert.java:743)

org.jboss.as.controller.test.GlobalOperationsTestCase.testRecursiveReadResourceDescriptionWithOperationsOperation: java.lang.AssertionError: expected:<12> but was:<20>
    at org.junit.Assert.fail(Assert.java:88)
    at org.junit.Assert.failNotEquals(Assert.java:743)

org.jboss.as.controller.test.GlobalOperationsTestCase.testReadOperationNamesOperation: java.lang.AssertionError: expected:<12> but was:<20>
    at org.junit.Assert.fail(Assert.java:88)
    at org.junit.Assert.failNotEquals(Assert.java:743)

org.jboss.as.controller.test.GlobalOperationsTestCase.testReadResourceDescriptionWithOperationsOperation: java.lang.AssertionError: expected:<12> but was:<20>
    at org.junit.Assert.fail(Assert.java:88)
    at org.junit.Assert.failNotEquals(Assert.java:743)

org.jboss.as.controller.test.RemoteChannelProxyControllerTestCase.testReadOperationNames: java.lang.AssertionError: expected:<11> but was:<19>
    at org.junit.Assert.fail(Assert.java:88)
    at org.junit.Assert.failNotEquals(Assert.java:743)

wildfly-ci · 2014-09-29T16:34:27Z

Windows Build 234 is now running using a merge of e147eb8

wildfly-ci · 2014-09-29T16:34:27Z

Linux Build 489 is now running using a merge of e147eb8

wildfly-ci · 2014-09-29T16:36:29Z

Windows Build 235 is now running using a merge of 74160d0

wildfly-ci · 2014-09-29T16:36:29Z

Linux Build 490 is now running using a merge of 74160d0

wildfly-ci · 2014-09-29T16:49:48Z

Windows Build 235 outcome was SUCCESS using a merge of 74160d0
Summary: Tests passed: 2600, ignored: 56 Build time: 0:13:19

wildfly-ci · 2014-09-29T16:52:42Z

Linux Build 490 outcome was SUCCESS using a merge of 74160d0
Summary: Tests passed: 2600, ignored: 56 Build time: 0:16:14

wildfly-ci · 2014-09-29T16:55:11Z

Linux Build 491 is now running using a merge of 74160d0

wildfly-ci · 2014-09-29T16:55:11Z

Windows Build 236 is now running using a merge of 74160d0

wildfly-ci · 2014-09-29T17:08:35Z

Windows Build 236 outcome was SUCCESS using a merge of 74160d0
Summary: Tests passed: 2600, ignored: 56 Build time: 0:13:25

wildfly-ci · 2014-09-29T17:11:20Z

Linux Build 491 outcome was SUCCESS using a merge of 74160d0
Summary: Tests passed: 2600, ignored: 56 Build time: 0:16:09

jamezp · 2014-09-30T01:11:04Z

controller/src/main/java/org/jboss/as/controller/operations/global/ListOperations.java

+        public void updateModel(final OperationContext context, ModelNode model, ListAttributeDefinition attributeDefinition, ModelNode listAttribute) throws OperationFailedException {
+            ModelNode value = VALUE.resolveModelAttribute(context, model);
+            ModelNode index = INDEX.resolveModelAttribute(context, model);
+            List<ModelNode> res = new LinkedList<>(listAttribute.asList());


An ArrayList should perform better here.

Not really sure about it, with arraylist it would mean copying array over on every remove.
for get operation arraylist is no brainier.

A LinkedList will use Collection.toArray() then create a new LinkedList.Node for each entry in the list. An ArrayList just copies the array with Collection.toArray(). Anyway, probably not a big deal. :)

ah missed that one, we are stuck with array creation in any case :)

bstansberry · 2014-09-30T18:32:54Z

controller/src/main/java/org/jboss/as/controller/operations/global/ListOperations.java

+ */
+public class ListOperations {
+
+    public static final OperationDefinition LIST_ADD_DEFINITION = new SimpleOperationDefinitionBuilder("list-add", new NonResolvingResourceDescriptionResolver())


These need descriptions, not NonResolvingResourceDescriptionResolver.

wildfly-ci · 2014-10-01T21:30:14Z

Windows Build 257 is now running using a merge of 68081fe

wildfly-ci · 2014-10-01T21:30:14Z

Linux Build 514 is now running using a merge of 68081fe

wildfly-ci · 2014-10-01T21:43:56Z

Windows Build 257 outcome was SUCCESS using a merge of 68081fe
Summary: Tests passed: 2601, ignored: 56 Build time: 0:13:42

wildfly-ci · 2014-10-01T21:46:36Z

Linux Build 514 outcome was SUCCESS using a merge of 68081fe
Summary: Tests passed: 2601, ignored: 56 Build time: 0:16:22

wildfly-ci · 2014-10-13T15:30:20Z

Linux Build 574 is now running using a merge of 0c4afe1

wildfly-ci · 2014-10-13T15:30:21Z

Windows Build 306 is now running using a merge of 0c4afe1

wildfly-ci · 2014-10-13T15:44:09Z

Windows Build 306 outcome was SUCCESS using a merge of 0c4afe1
Summary: Tests passed: 2603, ignored: 56 Build time: 0:13:51

wildfly-ci · 2014-10-13T15:47:10Z

Linux Build 574 outcome was SUCCESS using a merge of 0c4afe1
Summary: Tests passed: 2603, ignored: 56 Build time: 0:16:52

wildfly-ci · 2014-10-13T16:45:20Z

Windows Build 310 is now running using a merge of 1ba9b2f

wildfly-ci · 2014-10-13T16:45:20Z

Linux Build 578 is now running using a merge of 1ba9b2f

wildfly-ci · 2014-10-13T16:59:28Z

Windows Build 310 outcome was SUCCESS using a merge of 1ba9b2f
Summary: Tests passed: 2603, ignored: 56 Build time: 0:14:10

wildfly-ci · 2014-10-13T17:01:30Z

Linux Build 578 outcome was FAILURE using a merge of 1ba9b2f
Summary: Tests failed: 1 (1 new), passed: 2602, ignored: 56 Build time: 0:16:12

Build problems:

Failed tests detected

Failed tests

org.jboss.as.test.integration.domain.suspendresume.DomainGracefulShutdownTestCase.testGracefulShutdownDomainLevel: java.io.IOException: java.util.concurrent.ExecutionException: java.net.ConnectException: Connection refused
    at java.util.concurrent.FutureTask.report(FutureTask.java:122)
    at java.util.concurrent.FutureTask.get(FutureTask.java:202)

bstansberry · 2014-10-15T22:23:17Z

retest this please

wildfly-ci · 2014-10-15T22:25:19Z

Windows Build 321 is now running using a merge of 1ba9b2f

wildfly-ci · 2014-10-15T22:25:19Z

Linux Build 593 is now running using a merge of 1ba9b2f

wildfly-ci · 2014-10-15T22:39:32Z

Windows Build 321 outcome was SUCCESS using a merge of 1ba9b2f
Summary: Tests passed: 2687, ignored: 56 Build time: 0:14:14

wildfly-ci · 2014-10-15T22:42:19Z

Linux Build 593 outcome was SUCCESS using a merge of 1ba9b2f
Summary: Tests passed: 2687, ignored: 56 Build time: 0:17:01

WFCORE-14 - add operations for manipulating list & map attributes

[WFCORE-1442] Remove -XX:MaxMetaspaceSize=256m

ctomc force-pushed the managmenet branch from e147eb8 to 74160d0 Compare September 29, 2014 16:35

jamezp reviewed Sep 30, 2014
View reviewed changes

bstansberry reviewed Sep 30, 2014
View reviewed changes

ctomc force-pushed the managmenet branch from 74160d0 to 68081fe Compare October 1, 2014 21:25

bstansberry added ready-for-merge This PR is ready to be merged and fulfills all requirements rebase-this This PR must be rebased before it is merged labels Oct 6, 2014

ctomc force-pushed the managmenet branch from 68081fe to 0c4afe1 Compare October 13, 2014 15:29

WFCORE-14 - add operations for manipulating list & map attributes

1ba9b2f

ctomc force-pushed the managmenet branch from 0c4afe1 to 1ba9b2f Compare October 13, 2014 16:44

bstansberry removed the rebase-this This PR must be rebased before it is merged label Oct 15, 2014

bstansberry added a commit that referenced this pull request Oct 16, 2014

Merge pull request #206 from ctomc/managmenet

d4e3c92

WFCORE-14 - add operations for manipulating list & map attributes

bstansberry merged commit d4e3c92 into wildfly:master Oct 16, 2014

iweiss pushed a commit to iweiss/wildfly-core that referenced this pull request Jun 6, 2016

Merge pull request wildfly#206 from kabir/JBEAP-3874

92772c7

[WFCORE-1442] Remove -XX:MaxMetaspaceSize=256m

WFCORE-14 - add operations for manipulating list & map attributes #206

WFCORE-14 - add operations for manipulating list & map attributes #206

Conversation

ctomc commented Sep 29, 2014

wildfly-ci commented Sep 29, 2014

wildfly-ci commented Sep 29, 2014

wildfly-ci commented Sep 29, 2014

Build problems:

Failed tests

wildfly-ci commented Sep 29, 2014

Build problems:

Failed tests

wildfly-ci commented Sep 29, 2014

wildfly-ci commented Sep 29, 2014

wildfly-ci commented Sep 29, 2014

Build problems:

Failed tests

wildfly-ci commented Sep 29, 2014

Build problems:

Failed tests

wildfly-ci commented Sep 29, 2014

wildfly-ci commented Sep 29, 2014

wildfly-ci commented Sep 29, 2014

wildfly-ci commented Sep 29, 2014

wildfly-ci commented Sep 29, 2014

wildfly-ci commented Sep 29, 2014

wildfly-ci commented Sep 29, 2014

wildfly-ci commented Sep 29, 2014

wildfly-ci commented Sep 29, 2014

wildfly-ci commented Sep 29, 2014

jamezp Sep 30, 2014

Choose a reason for hiding this comment

ctomc Sep 30, 2014

Choose a reason for hiding this comment

jamezp Sep 30, 2014

Choose a reason for hiding this comment

ctomc Oct 1, 2014

Choose a reason for hiding this comment

bstansberry Sep 30, 2014

Choose a reason for hiding this comment

wildfly-ci commented Oct 1, 2014

wildfly-ci commented Oct 1, 2014

wildfly-ci commented Oct 1, 2014

wildfly-ci commented Oct 1, 2014

wildfly-ci commented Oct 13, 2014

wildfly-ci commented Oct 13, 2014

wildfly-ci commented Oct 13, 2014

wildfly-ci commented Oct 13, 2014

wildfly-ci commented Oct 13, 2014

wildfly-ci commented Oct 13, 2014

wildfly-ci commented Oct 13, 2014

wildfly-ci commented Oct 13, 2014

Build problems:

Failed tests

bstansberry commented Oct 15, 2014

wildfly-ci commented Oct 15, 2014

wildfly-ci commented Oct 15, 2014

wildfly-ci commented Oct 15, 2014

wildfly-ci commented Oct 15, 2014