[WFCORE-2717] try-catch block doesn't work if catch block doesn't contains anything #2361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfdenise
reviewed
Apr 25, 2017
| @@ -57,6 +57,7 @@ static TryCatchFinallyControlFlow get(CommandContext ctx) { | |||
| private int state; | |||
|
|
|||
| TryCatchFinallyControlFlow(CommandContext ctx) { | |||
| tryList = new ArrayList<>(); | |||
There was a problem hiding this comment.
You could make tryList final and perhaps inline initialisation in declaration.
There was a problem hiding this comment.
doing so, any check for null in the class (I think there are some) should be removed.
| @@ -97,6 +98,9 @@ boolean isInFinally() { | |||
| } | |||
|
|
|||
| void moveToCatch() throws CommandLineException { | |||
| if(catchList == null) { | |||
There was a problem hiding this comment.
You could move the list initialisation in the switch (IN_TRY). Doing so, no need to check for null and you will only initialise the list when needed.
| @@ -111,6 +115,9 @@ void moveToCatch() throws CommandLineException { | |||
| } | |||
|
|
|||
| void moveToFinally() throws CommandLineException { | |||
| if(finallyList == null) { | |||
There was a problem hiding this comment.
You could move the list initialisation in the switch (IN_TRY and IN_CATCH). Doing so, no need to check for null and you will only initialise the list when needed.
Seems that you could get rid-off a call to break and merge the 2 cases.
|
Windows Build 3419 outcome was FAILURE using a merge of 323ab73 Failed tests |
jfdenise
approved these changes
Apr 25, 2017
|
Windows Build 3420 outcome was FAILURE using a merge of 323ab73 Failed tests |
|
retest this please! |
|
Core - Full Integration Build 4764 outcome was FAILURE using a merge of 323ab73 |
|
Full integration - Windows Build 3191 outcome was FAILURE using a merge of 323ab73 Failed tests |
|
retest this please! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://issues.jboss.org/browse/WFCORE-2717