Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WFCORE-2968 Domain server auth service cleanup #2665

Merged
merged 1 commit into from
Jul 28, 2017
Merged

WFCORE-2968 Domain server auth service cleanup #2665

merged 1 commit into from
Jul 28, 2017

Conversation

luck3y
Copy link
Contributor

@luck3y luck3y commented Jul 26, 2017

This uncouples the domain server auth service from the realm add handler, and insteads starts it from DomainModelControllerService. This will allow the service to start if no realms are present.

@luck3y luck3y changed the title WFCORE-2968 Cleanup WFCORE-2968 Domain server auth service cleanup Jul 26, 2017
@luck3y luck3y force-pushed the WFCORE-2968-2 branch 4 times, most recently from 36debff to 51c1c7a Compare July 27, 2017 17:53
@luck3y luck3y mentioned this pull request Jul 27, 2017
Closed
@luck3y
Copy link
Contributor Author

luck3y commented Jul 27, 2017

retest this please

1 similar comment
@bstansberry
Copy link
Contributor

retest this please

@wildfly-ci
Copy link

Core - Full Integration Build 5549 outcome was UNKNOWN using a merge of 99876c5
Summary: Canceled (Tests passed: 510, ignored: 13; exit code 137 (new)) Build time: 00:03:13

@wildfly-ci
Copy link

Full integration - Windows Build 3973 outcome was UNKNOWN using a merge of 99876c5
Summary: Canceled (Tests passed: 89; exit code 1 (new)) Build time: 00:03:14

@luck3y
Copy link
Contributor Author

luck3y commented Jul 27, 2017

retest this please

@wildfly-ci
Copy link

Full integration - Windows Build 3974 outcome was UNKNOWN using a merge of 849178e
Summary: Canceled (Tests passed: 3302, ignored: 87; exit code 1 (new)) Build time: 00:58:03

@wildfly-ci
Copy link

Core - Full Integration Build 5550 outcome was UNKNOWN using a merge of 849178e
Summary: Canceled (Tests passed: 3451, ignored: 91; exit code 137 (new)) Build time: 00:58:03

@luck3y
Copy link
Contributor Author

luck3y commented Jul 27, 2017

retest this please

@luck3y
Copy link
Contributor Author

luck3y commented Jul 27, 2017

Note, cancelled and restarted with the improved version of test

bstansberry
bstansberry reviewed Jul 27, 2017
View reviewed changes
.../domain/src/test/java/org/jboss/as/test/integration/domain/ServerAuthenticationTestCase.java Outdated
import static org.jboss.as.controller.descriptions.ModelDescriptionConstants.SERVER;
import static org.jboss.as.controller.descriptions.ModelDescriptionConstants.SUCCESS;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertTrue;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codestyle is to put static imports first.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Odd, I had Intellij doing that automatically.

@luck3y
WFCORE-2968
1e99bdf 
- add test for domain server auth
- additional cleanup to start domain server auth seperately to realm add()
- allow servers to use local auth for connection
@bstansberry
Copy link
Contributor

retest this please

@bstansberry bstansberry merged commit b1ebbc0 into wildfly:master Jul 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bstansberry bstansberry bstansberry left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luck3y @bstansberry @wildfly-ci