Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WFLY-3781 Better warning messages in add-user.sh (.bat) #269

Merged
merged 2 commits into from Nov 1, 2014
Merged

WFLY-3781 Better warning messages in add-user.sh (.bat) #269

merged 2 commits into from Nov 1, 2014

Conversation

doobrie
Copy link
Contributor

@doobrie doobrie commented Oct 27, 2014

No description provided.

@wildfly-ci
Copy link

Windows Build 354 is now running using a merge of 268ddb6

@wildfly-ci
Copy link

Linux Build 631 is now running using a merge of 268ddb6

@wildfly-ci
Copy link

Windows Build 354 outcome was SUCCESS using a merge of 268ddb6
Summary: Tests passed: 2688, ignored: 56 Build time: 0:14:41

@wildfly-ci
Copy link

Linux Build 631 outcome was SUCCESS using a merge of 268ddb6
Summary: Tests passed: 2688, ignored: 56 Build time: 0:16:59

bstansberry
bstansberry reviewed Oct 27, 2014
View reviewed changes
core-feature-pack/src/main/resources/content/bin/add-user.bat
@@ -31,7 +31,7 @@ popd

if /i "%RESOLVED_JBOSS_HOME%" NEQ "%SANITIZED_JBOSS_HOME%" (
echo.
echo WARNING: JBOSS_HOME may be pointing to a different installation - unpredictable results may occur.
echo WARNING: The JBOSS_HOME ("%SANITIZED_JBOSS_HOME%") that this script uses points to a different installation to the one that this script resides in ("%RESOLVED_JBOSS_HOME%"). Unpredictable results may occur.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be "than the one" instead of "to the one".

@bstansberry
Copy link
Contributor

Thanks for this!

@wildfly-ci
Copy link

Linux Build 633 is now running using a merge of 7bd0809

@wildfly-ci
Copy link

Windows Build 356 is now running using a merge of 7bd0809

@doobrie
Copy link
Contributor Author

doobrie commented Oct 27, 2014

Thanks Brian, that wording sounds better. I've updated the branch with the changed wording.

@wildfly-ci
Copy link

Windows Build 356 outcome was SUCCESS using a merge of 7bd0809
Summary: Tests passed: 2688, ignored: 56 Build time: 0:14:07

@wildfly-ci
Copy link

Linux Build 633 outcome was SUCCESS using a merge of 7bd0809
Summary: Tests passed: 2688, ignored: 56 Build time: 0:17:18

@bstansberry bstansberry added the ready-for-merge This PR is ready to be merged and fulfills all requirements label Oct 31, 2014
bstansberry added a commit that referenced this pull request Nov 1, 2014
@bstansberry
Merge pull request #269 from doobrie/WFLY-3781
e173b71 
WFLY-3781 Better warning messages in add-user.sh (.bat)
@bstansberry bstansberry merged commit e173b71 into wildfly:master Nov 1, 2014
iweiss pushed a commit to iweiss/wildfly-core that referenced this pull request Jun 20, 2017
@kabir
Merge pull request wildfly#269 from jbossas/revert-263-JBEAP-3825-2
b91db99 
Revert "[JBEAP-3825] Upgrade JBoss Remoting to 4.0.21.Final"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ready-for-merge This PR is ready to be merged and fulfills all requirements
Projects
None yet
Milestone
No milestone
4 participants
@doobrie @wildfly-ci @bstansberry @davidsalter