Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WFCORE-3219] unignore AuditLogPeriodicRotatingFileHandlerTestCase.testRotate #2755

Closed
wants to merge 1 commit into from
Closed

[WFCORE-3219] unignore AuditLogPeriodicRotatingFileHandlerTestCase.testRotate #2755

wants to merge 1 commit into from

Conversation

kwart
Copy link
Contributor

@kwart kwart commented Sep 1, 2017

@bstansberry
Copy link
Contributor

How can we be smarter here?

@darranl
Copy link
Contributor

darranl commented Nov 16, 2017

@bstansberry Are you looking for some rework on the test?

jmesnil
jmesnil requested changes Feb 5, 2018
View reviewed changes
Copy link
Member

@jmesnil jmesnil left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can the test be faster to run?

The test takes more than 1 minute to run because it is sleeping for 61 seconds.

Could we change the rotating period to be smaller (e.g. at the second, with .yyyy-MM-dd-hh-mm-ss)?

@wolfc
Copy link
Contributor

wolfc commented Mar 19, 2018

Maybe put the test in a separate maven profile, so it only runs on CI machines?

@kwart
Copy link
Contributor Author

kwart commented Mar 20, 2018

As this will require more work, I'm closing this PR.

@kwart kwart closed this Mar 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmesnil jmesnil jmesnil requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@kwart @bstansberry @darranl @wolfc @jmesnil