Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WFCORE-216 Add ModelValidator to ensure resource model is correct #298

Merged
merged 1 commit into from Nov 7, 2014
Merged

WFCORE-216 Add ModelValidator to ensure resource model is correct #298

merged 1 commit into from Nov 7, 2014

Conversation

ctomc
Copy link
Contributor

@ctomc ctomc commented Nov 6, 2014

for review needs

@wildfly-ci
Copy link

Linux Build 708 is now running using a merge of 957f8d7

@wildfly-ci
Copy link

Windows Build 436 is now running using a merge of 957f8d7

bstansberry
bstansberry reviewed Nov 6, 2014
View reviewed changes
controller/src/test/java/org/jboss/as/controller/SimpleAttributeDefinitionUnitTestCase.java
Assert.fail("Should have worked but it failed with " + e.getMessage());
}

}*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this leftover from earlier work?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, from initial iteration that was doing stuff on AD directly.
Need to replace this tests with something that tests module validator properly.

@bstansberry
Copy link
Contributor

Looks good, although we should deal with write-attribute as much as we can as well.

Please post the link to the test against wf-full/master when it's done.

@wildfly-ci
Copy link

Windows Build 436 outcome was FAILURE using a merge of 957f8d7
Summary: Tests failed: 1 (1 new), passed: 2730, ignored: 58 Build time: 0:19:09

Build problems:

Failed tests detected

Failed tests

org.jboss.as.test.integration.domain.suites.OperationTransformationTestCase.test: org.jboss.as.test.integration.management.util.MgmtOperationException: Management operation failed.
    at org.jboss.as.test.integration.domain.management.util.DomainTestUtils.executeForResult(DomainTestUtils.java:157)
    at org.jboss.as.test.integration.domain.suites.OperationTransformationTestCase.test(OperationTransformationTestCase.java:113)

@wildfly-ci
Copy link

Linux Build 708 outcome was FAILURE using a merge of 957f8d7
Summary: Tests failed: 1 (1 new), passed: 2730, ignored: 58 Build time: 0:22:10

Build problems:

Failed tests detected

Failed tests

org.jboss.as.test.integration.domain.suites.OperationTransformationTestCase.test: org.jboss.as.test.integration.management.util.MgmtOperationException: Management operation failed.
    at org.jboss.as.test.integration.domain.management.util.DomainTestUtils.executeForResult(DomainTestUtils.java:157)
    at org.jboss.as.test.integration.domain.suites.OperationTransformationTestCase.test(OperationTransformationTestCase.java:113)

@wildfly-ci
Copy link

Core - Full Integration Build 1 is now running using a merge of 957f8d7

@wildfly-ci
Copy link

Core - Full Integration Build 1 outcome was FAILURE using a merge of 957f8d7
Summary: Exit code 1 (new) Build time: 0:00:06

Build problems:

Process exited with code 1

@wildfly-ci
Copy link

Core - Full Integration Build 2 is now running using a merge of 957f8d7

@wildfly-ci
Copy link

Core - Full Integration Build 2 outcome was FAILURE using a merge of 957f8d7
Summary: Tests failed: 1 (1 new), passed: 5461, ignored: 116 Build time: 0:44:36

Build problems:

Failed tests detected

Failed tests

org.jboss.as.test.integration.domain.suites.OperationTransformationTestCase.test: org.jboss.as.test.integration.management.util.MgmtOperationException: Management operation failed.
    at org.jboss.as.test.integration.domain.management.util.DomainTestUtils.executeForResult(DomainTestUtils.java:157)
    at org.jboss.as.test.integration.domain.suites.OperationTransformationTestCase.test(OperationTransformationTestCase.java:113)

@wildfly-ci
Copy link

Core - Full Integration Build 10 is now running using a merge of 5e8b169

@wildfly-ci
Copy link

Linux Build 715 is now running using a merge of 5e8b169

@wildfly-ci
Copy link

Windows Build 443 is now running using a merge of 5e8b169

@wildfly-ci
Copy link

Windows Build 443 outcome was SUCCESS using a merge of 5e8b169
Summary: Tests passed: 2733, ignored: 58 Build time: 0:20:15

@wildfly-ci
Copy link

Linux Build 715 outcome was SUCCESS using a merge of 5e8b169
Summary: Tests passed: 2733, ignored: 58 Build time: 0:22:22

@wildfly-ci
Copy link

Core - Full Integration Build 10 outcome was SUCCESS using a merge of 5e8b169
Summary: Tests passed: 5374, ignored: 347 Build time: 1:02:53

@bstansberry bstansberry added the ready-for-merge This PR is ready to be merged and fulfills all requirements label Nov 6, 2014
bstansberry added a commit that referenced this pull request Nov 7, 2014
@bstansberry
Merge pull request #298 from ctomc/mgmt-fixes
a81ce92 
WFCORE-216 Add ModelValidator to ensure resource model is correct
@bstansberry bstansberry merged commit a81ce92 into wildfly:master Nov 7, 2014
iweiss pushed a commit to iweiss/wildfly-core that referenced this pull request Jun 20, 2017
@bstansberry
Merge pull request wildfly#298 from dosoudil/JBEAP-6407
21996e9 
[JBEAP-6407] Upgrade xnio to 3.4.1.Final
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ready-for-merge This PR is ready to be merged and fulfills all requirements
Projects
None yet
Milestone
No milestone
3 participants
@ctomc @wildfly-ci @bstansberry