[WFCORE-269] CLI freezes and it's not possible to terminate it #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ctrl-C) in some cases
|
Can one of the admins verify this patch? |
| try { | ||
| Settings.getInstance().getInputStream().close(); // BZ-1149099 - enables interruption of active prompt | ||
| } catch (IOException e) { | ||
| e.printStackTrace(); |
There was a problem hiding this comment.
A stack trace isn't good here, as there's only one call stack that leads here. So it's scary looking but adds little value. Either ignore the exception or write out a message. Probably ignore the exception.
|
Looks good to me. Thanks, Tomas! |
|
@aloubyansky please approve |
removed stack trace printing
|
This is ok to test |
kabir
added a commit
that referenced
this pull request
Nov 20, 2014
[WFCORE-269] CLI freezes and it's not possible to terminate it
iweiss
pushed a commit
to iweiss/wildfly-core
that referenced
this pull request
Jun 20, 2017
[JBEAP-9239] Update to productized Commons Logging for LogManager
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[WFCORE-269] CLI freezes and it's not possible to terminate it
https://issues.jboss.org/browse/WFCORE-269