Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFCORE-4341] Upgrade Undertow version #3685

Merged
merged 1 commit into from
Feb 22, 2019
Merged

Conversation

fl4via
Copy link
Contributor

@fl4via fl4via commented Feb 20, 2019

@wildfly-ci
Copy link

Core - Full Integration Build 8365 outcome was FAILURE using a merge of 9f21cfc
Summary: Tests failed: 2 (2 new), passed: 4816, ignored: 133 Build time: 02:44:21

Failed tests

org.wildfly.extension.undertow.UndertowTransformersTestCase.testRejectTransformersEAP_7_1_0: java.lang.AssertionError: {"WFLYCTL0062: Composite operation failed and was rolled back. Steps that failed:" => {"Operation step-19" => "WFLYCTL0158: Operation handler failed: java.util.ServiceConfigurationError: io.undertow.attribute.ExchangeAttributeBuilder: Provider io.undertow.attribute.RemoteObfuscatedIPAttribute$Builder not a subtype"}}
	at org.jboss.as.model.test.ModelTestUtils.checkOutcome(ModelTestUtils.java:134)
	at org.jboss.as.model.test.ModelTestUtils.checkFailedTransformedBootOperations(ModelTestUtils.java:627)
	at org.wildfly.extension.undertow.UndertowTransformersTestCase.doRejectTest(UndertowTransformersTestCase.java:211)
	at org.wildfly.extension.undertow.UndertowTransformersTestCase.testRejectTransformersEAP_7_1_0(UndertowTransformersTestCase.java:152)


org.wildfly.extension.undertow.UndertowTransformersTestCase.testTransformersEAP_7_1_0: java.lang.AssertionError
	at org.wildfly.extension.undertow.UndertowTransformersTestCase.testTransformers(UndertowTransformersTestCase.java:271)
	at org.wildfly.extension.undertow.UndertowTransformersTestCase.testTransformers(UndertowTransformersTestCase.java:255)
	at org.wildfly.extension.undertow.UndertowTransformersTestCase.testTransformersEAP_7_1_0(UndertowTransformersTestCase.java:71)


@bstansberry
Copy link
Contributor

@kabir Any ideas? This failure indicates some sort of classloading problem:

java.lang.AssertionError: {"WFLYCTL0062: Composite operation failed and was rolled back. Steps that failed:" => {"Operation step-19" => "WFLYCTL0158: Operation handler failed: java.util.ServiceConfigurationError: io.undertow.attribute.ExchangeAttributeBuilder: Provider io.undertow.attribute.RemoteObfuscatedIPAttribute$Builder not a subtype"}}
	at org.junit.Assert.fail(Assert.java:88)
	at org.junit.Assert.assertTrue(Assert.java:41)
	at org.jboss.as.model.test.ModelTestUtils.checkOutcome(ModelTestUtils.java:134)
	at org.jboss.as.model.test.ModelTestUtils.checkFailedTransformedBootOperations(ModelTestUtils.java:627)
	at org.wildfly.extension.undertow.UndertowTransformersTestCase.doRejectTest(UndertowTransformersTestCase.java:211)
	at org.wildfly.extension.undertow.UndertowTransformersTestCase.testRejectTransformersEAP_7_1_0(UndertowTransformersTestCase.java:152)

RemoteObfuscatedIPAttribute is new in 2.0.18 and is listed there in a META-INF/services/io.undertow.attribute.ExchangeAttributeBuilder file. This Error indicates a ServiceLoader is doing its thing, is finding this entry, trying to load the service impl but failing because the service impl is not implementing the expected interface. That tells me the expected interface is from the legacy undertow version but somehow 2.0.18 is visible too.

This shows that for EAP 7.1 transformer tests the legacy controller should be using the legacy undertow jars:

https://github.com/wildfly/wildfly/blob/master/undertow/src/test/java/org/wildfly/extension/undertow/UndertowTransformersTestCase.java#L280

So I see pieces of the puzzle but don't really know what to do with them yet.

@bstansberry
Copy link
Contributor

bstansberry commented Feb 21, 2019

Never mind @kabir -- we figured out a solution. Temporary workaround

wildfly/wildfly#12098

and a longer term fix

https://issues.jboss.org/browse/WFCORE-4346

@bstansberry
Copy link
Contributor

retest this please

@bstansberry
Copy link
Contributor

I put the hold label on this as there's another release planned.

@fl4via
Copy link
Contributor Author

fl4via commented Feb 22, 2019

Retest this please

@bstansberry bstansberry removed the hold Do not merge this PR label Feb 22, 2019
@bstansberry bstansberry merged commit 2c2f31e into wildfly:master Feb 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants