[WFCORE-4381] Don't stop the DomainTestSupport before relaunching the… #3709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… HCs. Just stop the HCs. Stopping the DomainTestSupport also closes down the shared client side Endpoint, and the DomainLifecycleUtil objects use those. Closing it down is what led to the need for unusual start handling after the DomainTestSupport.stop() call. I also clean out the try with resources handling with the client. The client from DomainLifecycleUtil can now be used and doesn't have to be closed by the test method.
jmesnil
approved these changes
Mar 25, 2019
jmesnil
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… HCs. Just stop the HCs.
Stopping the DomainTestSupport also closes down the shared client side Endpoint, and the DomainLifecycleUtil objects use those. Closing it down is what led to the need for unusual start handling after the DomainTestSupport.stop() call.
I also clean out the try with resources handling with the client. The client from DomainLifecycleUtil can now be used and doesn't have to be closed by the test method.
https://issues.jboss.org/browse/WFCORE-4381
https://github.com/wildfly/wildfly-core/pull/3709/files?w=1 is a good way to look at this as there's a big whitespace diff due to removing try blocks.