[WFCORE-4774] Avoid circular recursion searching for capability status

[yersan]

We could have capabilities with circular requirements, e.g. an attribute that adds a capability reference from a parent capability to a child capability when the child capability already requires its parent.

In those cases, when the server is in restart-required and the capability to check is not the one that was recorded as restart-required, a stack overflow exception is thrown.

Jira issue: https://issues.redhat.com/browse/WFCORE-4774

[yersan]

This is the only relevant change, move it outside of the previous if to make it count when we have capabilities in the restartCapabilities. I'm not sure what was the original intention, looks like it was expected to have it in the restartCapabilities array, but that's not always true. I renamed it to visited instead of examined, since examined could mean already checked its status, which is not correct at this point. At the end of this method, the capability is checked (examined) to see if it is in the reloadCapabilities. I found visited more adequate.

[wildfly-ci]

Core - Full Integration Build 9245 outcome was UNKNOWN using a merge of 38aed9f
Summary: Canceled (Tests passed: 999, ignored: 14; exit code 143 (Step: Build & test full (Maven)) (new)) Build time: 00:21:13

[wildfly-ci]

Core - Full Integration Build 9243 outcome was UNKNOWN using a merge of 38aed9f
Summary: Canceled (Tests passed: 1857, ignored: 35; exit code 143 (Step: Build & test full (Maven)) (new)) Build time: 00:21:13

[jmesnil]

@yersan thanks