Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFCORE-591] NPE in revertReloadRequired #559

Merged

Conversation

jmesnil
Copy link
Member

@jmesnil jmesnil commented Mar 12, 2015

Prevent revertReloadRequired (resp. revertRestartReloadRequired) to
throw a NPE if reloadRequired (resp. restartRequired) as not been called
beforehands.

JIRA: https://issues.jboss.org/browse/WFCORE-591

Prevent revertReloadRequired (resp. revertRestartReloadRequired) to
throw a NPE if reloadRequired (resp. restartRequired) as not been called
beforehands.

JIRA: https://issues.jboss.org/browse/WFCORE-591
@wildfly-ci
Copy link

Core - Full Integration Build 625 is now running using a merge of 36645e8

@wildfly-ci
Copy link

Windows Build 1045 is now running using a merge of 36645e8

@wildfly-ci
Copy link

Linux Build 1374 is now running using a merge of 36645e8

@wildfly-ci
Copy link

Linux Build 1374 outcome was SUCCESS using a merge of 36645e8
Summary: Tests passed: 3074, ignored: 64 Build time: 0:18:46

@wildfly-ci
Copy link

Windows Build 1045 outcome was SUCCESS using a merge of 36645e8
Summary: Tests passed: 3074, ignored: 64 Build time: 0:18:59

@wildfly-ci
Copy link

Core - Full Integration Build 625 outcome was SUCCESS using a merge of 36645e8
Summary: Tests passed: 2830, ignored: 412 Build time: 0:49:01

@bstansberry bstansberry added the ready-for-merge This PR is ready to be merged and fulfills all requirements label Mar 12, 2015
@bstansberry
Copy link
Contributor

I'm tempted to say we should have asserts there, as this sounds like a programming error. But this is fine.

bstansberry added a commit that referenced this pull request Mar 13, 2015
@bstansberry bstansberry merged commit 1cdc1ff into wildfly:master Mar 13, 2015
iweiss pushed a commit to iweiss/wildfly-core that referenced this pull request Aug 15, 2018
[JBEAP-14805] update test schema version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge This PR is ready to be merged and fulfills all requirements
Projects
None yet
3 participants