Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFCORE-6819] Show current stability level with the server boot message #6000

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

yersan
Copy link
Collaborator

@yersan yersan commented May 16, 2024

@github-actions github-actions bot added the deps-ok Dependencies have been checked, and there are no significant changes label May 16, 2024
@@ -1475,6 +1475,9 @@ public interface ServerLogger extends BasicLogger {
@Message(id = Message.NONE, value = "- Server configuration file in use: %s")
String serverConfigFileInUse(String serverConfigFile);

@Message(id = Message.NONE, value = "- Server Stability level: %s")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think something like

"Minimum feature stability level: %s"

This setting doesn't describe the overall stability of the server or even most of its features. And many readers of the message will have no idea what this means, so it can't be alarming.

Copy link
Collaborator Author

@yersan yersan May 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bstansberry Done, using "Minimum feature stability level: %s" for server and host controller. I also removed the Server and Host Controller words from the sentence since the previous sentences of the same message already establish such a context, let me know otherwise.

@bstansberry
Copy link
Contributor

/retest

@wildfly-ci
Copy link

Core -> WildFly Preview Integration Build 13663 outcome was FAILURE using a merge of 165116d
Summary: Tests failed: 1 (1 new), passed: 5006, ignored: 85 Build time: 03:12:25

Failed tests

org.wildfly.test.integration.microprofile.jwt.propagation.JWTIdentityPropagationTestCase(layers-test).testInvokeEJBWithinSingleDeploymentOutflowNotPossibleTrustNotConfigured: java.lang.AssertionError: Call was authenticated
	at org.wildfly.test.integration.microprofile.jwt.propagation.JWTIdentityPropagationTestCase.testInvokeEJB(JWTIdentityPropagationTestCase.java:335)
	at org.wildfly.test.integration.microprofile.jwt.propagation.JWTIdentityPropagationTestCase.testInvokeEJBWithinSingleDeploymentOutflowNotPossibleTrustNotConfigured(JWTIdentityPropagationTestCase.java:255)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at jdk.internal.reflect.GeneratedMethodAccessor18.invoke(Unknown Source)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at jdk.internal.reflect.GeneratedMethodAccessor17.invoke(Unknown Source)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at jdk.internal.reflect.GeneratedMethodAccessor16.invoke(Unknown Source)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at jdk.internal.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at jdk.internal.reflect.GeneratedMethodAccessor3.invoke(Unknown Source)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at jdk.internal.reflect.GeneratedMethodAccessor2.invoke(Unknown Source)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at jdk.internal.reflect.GeneratedMethodAccessor6.invoke(Unknown Source)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at jdk.internal.reflect.GeneratedMethodAccessor5.invoke(Unknown Source)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at jdk.internal.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at jdk.internal.reflect.GeneratedMethodAccessor3.invoke(Unknown Source)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at jdk.internal.reflect.GeneratedMethodAccessor2.invoke(Unknown Source)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)


@yersan yersan added the ready-for-merge This PR is ready to be merged and fulfills all requirements label Jun 13, 2024
@yersan yersan merged commit 895d95b into wildfly:main Jun 17, 2024
11 of 12 checks passed
@yersan yersan deleted the WFCORE-6819 branch June 17, 2024 09:17
@yersan
Copy link
Collaborator Author

yersan commented Jun 17, 2024

Thanks @bstansberry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deps-ok Dependencies have been checked, and there are no significant changes ready-for-merge This PR is ready to be merged and fulfills all requirements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants