[WFCORE-6732] WildFlyRunner doesn't call tearDown and completed ServerSetupTasks if a later one fails in setup #6017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
deps-ok
yersan
reviewed
Jun 4, 2024
Comment on lines
195
to
199
| if (setupException == null) { | ||
| super.run(notifier); | ||
| } |
There was a problem hiding this comment.
Before this change, if an AssumptionViolatedException gets thrown, the super.run(notifier); was executed. Now, we are introducing a change here. I'm not familiar with JUInit runners, are there any side effects?
There was a problem hiding this comment.
IMO, it won't introduce a change here. With the change, the super.run(notifier) will also be executed when AssumptionViolatedException was thrown from runSetupTasks(), the setupException is null in that case.
There was a problem hiding this comment.
Ups, right @gaol , apologies, I made a mistake with this
testsuite/test-runner/src/main/java/org/wildfly/core/testrunner/WildFlyRunner.java
Outdated
Show resolved
Hide resolved
…rSetupTasks if a later one fails in setup
yersan
approved these changes
Jun 5, 2024
yersan
added
the
ready-for-merge
|
Thanks @gaol |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://issues.redhat.com/browse/WFCORE-6732
Not sure if a test case needs to be added and where to add if so, please let me know :)