Don't close the MessageInputStream after signalling the arrival of a response, it will get closed after the response has been handled #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was running into a problem where an
EOFException
would sometimes occur in RemoteClientTransport#lookup. It seems that the underlying issue was that theMessageInputStream
was being closed after signalling the arrival of a response, beforeRemoteClientTransport#lookup
had a chance to actually handle the response. This PR fixes this by no longer closing theMessageInputStream
after signalling the arrival of a response (it gets closed inRemoteClientTransport#lookup
after the response has been handled).