[WFCORE-5027] Adding a proposal for charset and encoding support for credentials in security realms #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SoniaZaldana
force-pushed
the
WFCORE-5027
branch
2 times, most recently
from
1133be9
to
75f6fee
Compare
fjuma
reviewed
Jul 16, 2020
| ``hash-charset`` to the ``set-password`` operation as follows: | ||
|
|
||
|
|
||
| /subsystem=elytron/filesystem-realm=fsRealm:set-password(identity=user1, digest={algorithm=digest=md5, password=password123, hash-encoding=hex, hash-charset=UTF-16}) |
There was a problem hiding this comment.
Just a very minor typo, s/digest=md5/digest-md5.
fjuma
reviewed
Jul 16, 2020
|
|
||
| === Hard Requirements | ||
|
|
||
| All realms that support hashed passwords need to be modified: Properties Realm, Filesystem Realm, JDBC Realm, and LDAP Realm. |
There was a problem hiding this comment.
Would be good to add links to the corresponding Java classes.
|
Nice analysis, @SoniaZaldana! |
SoniaZaldana
force-pushed
the
WFCORE-5027
branch
3 times, most recently
from
88b51b1
to
3db24fe
Compare
SoniaZaldana
commented
Jul 16, 2020
| used when verifying every single client-provided password against the credentials stored in the | ||
| security realm, as long as hashing is enabled. The only difference lies in that the Elytron Properties realm | ||
| only allows ClearPasswords or DigestPasswords, as opposed to the ``UserRolesLoginModule`` which supports a wider variety of | ||
| hashing algorithms. Supporting more hashing algorithms is out of the scope of this RFE. |
There was a problem hiding this comment.
For now, I have written that supporting all the hashing algorithms that legacy supported is out of the scope of this RFE. Should it be included?
SoniaZaldana
force-pushed
the
WFCORE-5027
branch
from
3db24fe
to
eac337a
Compare
SoniaZaldana
force-pushed
the
WFCORE-5027
branch
from
eac337a
to
dadfac1
Compare
fjuma
approved these changes
May 27, 2021
…credentials in security realms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/WFCORE-5027