Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFLY-9915] Narayana component upgrade to 5.8.0.Final #10950

Conversation

ochaloup
Copy link
Contributor

@ochaloup ochaloup commented Feb 27, 2018

@kabir kabir added the Feature PR provides a new feature label Feb 28, 2018
@stuartwdouglas stuartwdouglas added the rebase-this PR has a merge conflict. label Mar 6, 2018
@stuartwdouglas
Copy link
Contributor

Needs a rebase

@ochaloup ochaloup force-pushed the WFLY-9915-narayana-component-upgrade-5.8.0.Final branch from e2a59e0 to 9523681 Compare March 6, 2018 10:59
@ochaloup
Copy link
Contributor Author

ochaloup commented Mar 6, 2018

@stuartwdouglas rebased

@stuartwdouglas stuartwdouglas removed the rebase-this PR has a merge conflict. label Mar 12, 2018
@stuartwdouglas
Copy link
Contributor

Is this actually the feature PR? I have not merged this as I was waiting for the relevant QE analysis + test development to be done, however it sounds like the feature will be something that will need to be enabled via the XTS subsystem?

In that case I think we can just call this a component upgrade rather than a feature, and have a seperate PR for the XTS subsystem changes+tests to enable this new feature.

@ochaloup
Copy link
Contributor Author

ochaloup commented Mar 12, 2018

@stuartwdouglas : yes, true, this should be called just component upgrade. I'm sorry as I made some mess in the description.
It's as you described. The XTS part needs to be enabled in the XTS subsystem and there will come separate PR for that (after this will be merged as the XTS subsystem change depends on the new code in the Narayana XTS library). As said the PR for the feature request will need to be confirmed by the QE analysis.

In summary - this is a component upgrade consisting several bug fixes and preparation for the XTS feature being enabled in the WFLY code.

@stuartwdouglas stuartwdouglas added ready-for-merge Only for use by those with merge permissions! and removed Feature PR provides a new feature labels Mar 12, 2018
@stuartwdouglas stuartwdouglas merged commit ab0d5c8 into wildfly:master Mar 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge Only for use by those with merge permissions!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants