[WFLY-9707] Remove the JASPI module from the feature pack as this is now in the core feature pack. #11474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…now in the core feature pack.
kabir
added
the
core-upgrade-needed
yersan
reviewed
Aug 1, 2018
| <dependency> | ||
| <groupId>org.jboss.spec.javax.security.auth.message</groupId> | ||
| <artifactId>jboss-jaspi-api_1.1_spec</artifactId> | ||
| </dependency> |
There was a problem hiding this comment.
It should be also removed from servlet-galleon-pack/pom.xml
There was a problem hiding this comment.
Note to self this has now been done
… as this is now added via the Core pack.
|
Retest this please |
|
@kabir I think we are still missing the related core update for this one. |
|
retest this please |
jamezp
removed
the
core-upgrade-needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request depends on the WildFly Core PR wildfly/wildfly-core#3407
Thanks for submitting your Pull Request!
Please make sure your PR meets the following requirements:
[WFLY-XYZ] SubjectorWFLY-XYZ SubjectThe JASPI module is required in WildFly Core for the Elytron subsystem to depend on it, this change is to remove it from WildFly as we do not need to define it twice.
For bigger changes, major and minor component upgrades make sure your PR also meets following requirements:
For new features ensure as well:
If you are not an active contributor of the WildFly project you can request sponsorship by one of the members to help guide you through the process.