Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFLY-11676] Documentation for feature that provides ability to list module dependencies of a deployed application #12041

Merged
merged 1 commit into from
Feb 12, 2019

Conversation

yersan
Copy link
Contributor

@yersan yersan commented Feb 6, 2019

Community documentation for WFCORE-4251, which provides the ability to list modules which are on deployment's classpath.

Jira issue: https://issues.jboss.org/browse/WFLY-11676
Analysis doc: wildfly/wildfly-proposals#159

@kabir kabir added core-upgrade-needed PR requires a wildfly-core change to be merged and integrated first Feature-Docs PR documents a new feature coming via WildFly Core labels Feb 7, 2019
Copy link
Contributor

@bstansberry bstansberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look nice. You are good at docs! Here and elsewhere. I've got a number of trivial comments but I only spend the time for that kind of polish because these are really nice. Only substantive change is the last comment about import-services.

[[how-to-list-the-module-dependencies-of-a-deployed-application]]
== How to list the module dependencies of a deployed application

In Wildfly it is possible to list the module dependencies added by the container to your deployed application. This task can be achieved via the command line interface, where specific commands are available to list the module dependencies for deployments and ear-subdeployments.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/commands/operations

In CLI terms a 'command' is a high level command, while an 'operation' is for the stuff that gets parsed into DMR.

[standalone@localhost:9990 /] /deployment=test-application.war:list-modules
----

In case of ear-subdeployments, the _list-modules_ command is also available under subdeployment resource:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/under/under the/g

[standalone@localhost:9990 /] /deployment=test-application.ear/subdeployment=test-application.war:list-modules
----

If you are running Wildfly in a domain mode, this operation is available via the server resource at host level:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/a domain/domain/g
s/at host/at the host/g

[domain@localhost:9990 /] /host=master/server=server-one/deployment=test-application.ear/subdeployment=test-application.war:list-modules
----

By default, _list-modules_ operation shows the list of dependencies in a compact view, including only the module name. You can control this output using the attribute _verbose=[false*|true]_ to enabling/disabling a detailed response.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/default,/default, the/g
s/enabling/enable/g
s/disabling/disable/g

----


The _list_modules_ command shows information in three different categories:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/command/operation


* system-dependencies: These are the dependencies added implicitly by the server container.
* local-dependencies: These are dependencies on other parts of the deployment.
* user-dependencies: These are the dependencies defined by the user via manifest file or deployment-structure.xml.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/via/via a/g


For each module, the following information is shown:

* name: The module name and, if the slot name is not the default "main" slot, the slot name is concatenated after ":" character separator.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/after/after a/g

* name: The module name and, if the slot name is not the default "main" slot, the slot name is concatenated after ":" character separator.
* optional: If the dependency was added as an optional dependency.
* export: If the dependency is being exported to other modules.
* import-services: If this module is importing services from other dependencies.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this more like

"If the module for the deployment or subdeployment is allowed to import services from the dependency."

?

That's the meaning of a 'services="import"' attribute on a dependency element in module.xml and looking at the setting of org.jboss.as.server.deployment.module.ModuleDependency.isImportServices() it is 'true' in the 'services="import"' situation, 'false' otherwise.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, "allowed to import" is a much better description.

…module dependencies of a deployed application

[WFLY-11676] Correction in the documentation
@yersan
Copy link
Contributor Author

yersan commented Feb 8, 2019

@bstansberry I've just addressed all the points, thank you for the review.

@bstansberry bstansberry removed the core-upgrade-needed PR requires a wildfly-core change to be merged and integrated first label Feb 12, 2019
@kabir kabir merged commit b8b0d16 into wildfly:master Feb 12, 2019
@yersan yersan deleted the docs/WFLY-11676 branch February 12, 2019 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature-Docs PR documents a new feature coming via WildFly Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants