-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WFLY-11676] Documentation for feature that provides ability to list module dependencies of a deployed application #12041
Conversation
docs/src/main/asciidoc/_developer-guide/Class_Loading_in_WildFly.adoc
Outdated
Show resolved
Hide resolved
48ee499
to
6d0ef6c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These look nice. You are good at docs! Here and elsewhere. I've got a number of trivial comments but I only spend the time for that kind of polish because these are really nice. Only substantive change is the last comment about import-services.
[[how-to-list-the-module-dependencies-of-a-deployed-application]] | ||
== How to list the module dependencies of a deployed application | ||
|
||
In Wildfly it is possible to list the module dependencies added by the container to your deployed application. This task can be achieved via the command line interface, where specific commands are available to list the module dependencies for deployments and ear-subdeployments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/commands/operations
In CLI terms a 'command' is a high level command, while an 'operation' is for the stuff that gets parsed into DMR.
[standalone@localhost:9990 /] /deployment=test-application.war:list-modules | ||
---- | ||
|
||
In case of ear-subdeployments, the _list-modules_ command is also available under subdeployment resource: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/under/under the/g
[standalone@localhost:9990 /] /deployment=test-application.ear/subdeployment=test-application.war:list-modules | ||
---- | ||
|
||
If you are running Wildfly in a domain mode, this operation is available via the server resource at host level: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/a domain/domain/g
s/at host/at the host/g
[domain@localhost:9990 /] /host=master/server=server-one/deployment=test-application.ear/subdeployment=test-application.war:list-modules | ||
---- | ||
|
||
By default, _list-modules_ operation shows the list of dependencies in a compact view, including only the module name. You can control this output using the attribute _verbose=[false*|true]_ to enabling/disabling a detailed response. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/default,/default, the/g
s/enabling/enable/g
s/disabling/disable/g
---- | ||
|
||
|
||
The _list_modules_ command shows information in three different categories: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/command/operation
|
||
* system-dependencies: These are the dependencies added implicitly by the server container. | ||
* local-dependencies: These are dependencies on other parts of the deployment. | ||
* user-dependencies: These are the dependencies defined by the user via manifest file or deployment-structure.xml. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/via/via a/g
|
||
For each module, the following information is shown: | ||
|
||
* name: The module name and, if the slot name is not the default "main" slot, the slot name is concatenated after ":" character separator. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/after/after a/g
* name: The module name and, if the slot name is not the default "main" slot, the slot name is concatenated after ":" character separator. | ||
* optional: If the dependency was added as an optional dependency. | ||
* export: If the dependency is being exported to other modules. | ||
* import-services: If this module is importing services from other dependencies. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this more like
"If the module for the deployment or subdeployment is allowed to import services from the dependency."
?
That's the meaning of a 'services="import"' attribute on a dependency element in module.xml and looking at the setting of org.jboss.as.server.deployment.module.ModuleDependency.isImportServices() it is 'true' in the 'services="import"' situation, 'false' otherwise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, "allowed to import" is a much better description.
6d0ef6c
to
4df0105
Compare
…module dependencies of a deployed application [WFLY-11676] Correction in the documentation
4df0105
to
7b2a0d4
Compare
@bstansberry I've just addressed all the points, thank you for the review. |
Community documentation for WFCORE-4251, which provides the ability to list modules which are on deployment's classpath.
Jira issue: https://issues.jboss.org/browse/WFLY-11676
Analysis doc: wildfly/wildfly-proposals#159