Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update subsystem transformer and mixed domain tests to use EAP 7.2 #12049

Merged
merged 4 commits into from Feb 12, 2019

Conversation

@kabir kabir closed this Feb 8, 2019
@kabir kabir reopened this Feb 8, 2019
@kabir kabir force-pushed the update-model-test-controller-version branch from 97f0201 to b1dc661 Compare February 8, 2019 15:10
@kabir kabir added the core-upgrade-needed PR requires a wildfly-core change to be merged and integrated first label Feb 8, 2019
Copy link
Member

@rhusar rhusar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thx!

@rhusar
Copy link
Member

rhusar commented Feb 11, 2019

PS: I would say next time just use EAP_7_2_0 for the name straightaway rather than temporary names, so we don't have to make changes across the source tree; the only change needed would be changing the container from WF to EAP.

@kabir
Copy link
Contributor Author

kabir commented Feb 11, 2019

Yeah, my approach made sense at the time (my thinking was it was a signal to update maven deps pulled in via the LegacyKernelServicesInitializer) but I've learnt the hard way now.

@rhusar
Copy link
Member

rhusar commented Feb 11, 2019

I guess the advantage would have been should things go very awry with WF 16 as a target, it could be disabled while more EAP 7.2 as a target tests be added... but that would be unlikely.

@kabir
Copy link
Contributor Author

kabir commented Feb 11, 2019

Retest this please

@bstansberry bstansberry removed the core-upgrade-needed PR requires a wildfly-core change to be merged and integrated first label Feb 12, 2019
@kabir kabir force-pushed the update-model-test-controller-version branch from b1dc661 to 4aa3aaf Compare February 12, 2019 11:26
@kabir kabir merged commit 3be1b54 into wildfly:master Feb 12, 2019
@kabir kabir deleted the update-model-test-controller-version branch February 12, 2019 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants