Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFLY-11748] Upgrade hibernate components #12090

Merged
merged 2 commits into from
Feb 21, 2019
Merged

Conversation

langfr
Copy link
Contributor

@langfr langfr commented Feb 19, 2019

Upgrade Hibernate components

  • Core 5.3.7 --> 5.3.8
  • Commons Annotations 5.0.4 --> 5.0.5
  • Search 5.10.3 --> 5.10.5

Linked to https://issues.jboss.org/browse/WFLY-11748

@bstansberry
Copy link
Contributor

Thanks! We'll handle any ORM change via #12091.

@bstansberry
Copy link
Contributor

@scottmarlow @Sanne Is this ok for WF 16?

@Sanne
Copy link
Member

Sanne commented Feb 20, 2019

@bstansberry looks good. @yrodiere is leading Search now; Yoann you're fine with the Search upgrade?

@yrodiere
Copy link
Contributor

@bstansberry @Sanne Yes the Search upgrade is fine. It's mainly changes in the build, an upgrade of ORM dependencies, and a few bugfixes.

@scottmarlow
Copy link
Contributor

Hibernate ORM 5.3.8, is using hibernate-common-annotations 5.0.4.Final, not 5.0.5.Final. @yrodiere does HibernateSearch 5.10.5 work with hibernate-common-annotations 5.0.4.Final?

@Sanne
Copy link
Member

Sanne commented Feb 20, 2019

Hibernate ORM 5.3.8, is using hibernate-common-annotations 5.0.4.Final, not 5.0.5.Final. @yrodiere does HibernateSearch 5.10.5 work with hibernate-common-annotations 5.0.4.Final?

The only difference is 5.0.5.Final was compiled with JBoss Logging 3.3.2.Final. I would suggest using 5.0.5.Final.

@yrodiere
Copy link
Contributor

@scottmarlow As Sanne said, 5.0.5.Final is essentially 5.0.4.Final compiled against a different JBoss Logging version, no other change: hibernate/hibernate-commons-annotations@5.0.4.Final...5.0.5.Final
So yes it would work, but I think you will want to use 5.0.5.Final in WildFly.

@scottmarlow
Copy link
Contributor

@scottmarlow @Sanne Is this ok for WF 16?

@bstansberry as per above feedback on hibernate-commons-annotations, the upgrade to version 5.0.5.Final, is fine to include in WF16, as well as the Search + ORM upgrades.

@bstansberry bstansberry merged commit 06e0d58 into wildfly:master Feb 21, 2019
@bstansberry
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants