WFLY-12759 Extract microprofile-config galleon layer from observability #12776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bstansberry
reviewed
Nov 5, 2019
wildfly-ci
added
the
deps-ok
bstansberry
requested changes
Nov 5, 2019
There was a problem hiding this comment.
This will need an entry in the testsuite/layers/pom.xml. All layers should have an entry there as that is the basic boot validation for the layer.
It also needs an update to https://github.com/wildfly/wildfly/blob/master/docs/src/main/asciidoc/_admin-guide/Galleon_provisioning.adoc
pferraro
force-pushed
the
microprofile
branch
from
f242b47
to
4119ade
Compare
|
@bstansberry Fixed. |
bstansberry
approved these changes
Nov 6, 2019
bstansberry
added
ready-for-merge
|
@jmesnil OK with you? |
|
Actually, would it make any sense to document this in |
|
@rhusar MicroProfile Config is usable directly by applications, so any layer at all could possibly be decorated with this one. It seems simpler to document them all too. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jboss.org/browse/WFLY-12759
Microprofile specs like OpenAPI don't require metrics nor health, suggesting the microprofile layers should be more granular.