WFLY-13176 Add jboss-ejb-client_1_3.xsd schema #13151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have added a jboss-ejb-client_1_3.xsd schema. Please review and let me know what you think ! :) |
wildfly-ci
added
the
deps-ok
chengfang
reviewed
Mar 26, 2020
| </xsd:annotation> | ||
| </xsd:attribute> | ||
| </xsd:complexType> | ||
|
|
There was a problem hiding this comment.
need to fix the indentation, eg. replace tab with space consistent with other elements.
chengfang
reviewed
Mar 26, 2020
| <xsd:annotation> | ||
| <xsd:documentation> | ||
| Cluster configurations applicable for this client context | ||
| </xsd:documentation> |
There was a problem hiding this comment.
need to change documentation to reflect the purpose of the new element. Probably something like Remoten connection profile selected for this client context.
|
@tadamski please review
|
chengfang
approved these changes
Mar 27, 2020
rhusar
suggested changes
Mar 27, 2020
|
|
||
| <!-- | ||
| ~ JBoss, Home of Professional Open Source. | ||
| ~ Copyright 2012, Red Hat, Inc., and individual contributors |
There was a problem hiding this comment.
Previously I thought I would change it to 2020 but I was not sure about how the copyright thing works.You can check now, I have made the changes. :)
tadamski
approved these changes
Mar 31, 2020
bstansberry
added
the
ready-for-merge
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/WFLY-13176