[WFLY-13695] Upgrade wildfly-http-client to 1.0.23.Final

[fl4via]

Jira: https://issues.redhat.com/browse/WFLY-13695
20.x PR (in case one is needed): #13423

    Release Notes - WildFly EJB HTTP Client - Version 1.0.23.Final

Bug

• [WEJBHTTP-47] - Ensure the HttpRemoteTransactionPeer captures current AuthenticationContext and SSLContext

    Release Notes - WildFly EJB HTTP Client - Version 1.0.22.Final

Bug

• [WEJBHTTP-45] - UT000103 thrown when WildflyClientOutputStream size is exactly 1024 bytes

[bstansberry]

@fl4via I just started another run but so far the security manager CI job has failed twice with what looks at a glance like the same failure pattern.

https://ci.wildfly.org/viewType.html?buildTypeId=WF_PullRequest_LinuxSm&branch_WF_PullRequest=pull%2F13422&tab=buildTypeStatusDiv

[bstansberry]

It's failing again so there must be some issue.

[bstansberry]

@fl4via any update?

[spyrkob]

FYI the secmgr tests passed without issues in the downstream PR

[fl4via]

@bstansberry @spyrkob I don't know why we're seeing this kind of error. I remember when we're working on wildfly-http-client fix that I was running some tests with security enabled, but everything seemed fine on the tests I ran and I don't recall the details now. I'll investigate the failing tests in my machine to find out what's going on.

[spyrkob]

It looks like trying to remove transaction recovery files fails with secmgr.

There's following stack trace in the logs:

2020-08-25 11:57:09,108 WARN [com.arjuna.ats.arjuna] (pool-11-thread-1) ARJUNA012091: Top-level abort of action 0:1:-7a70fe34:5f44ee7a:33 received TwoPhaseOutcome.FINISH_ERROR from com.arjuna.ats.internal.jta.resources.arjunacore.XAResourceRecord 2020-08-25 11:57:09,149 WARN [com.arjuna.ats.jta] (pool-11-thread-1) ARJUNA016045: attempted rollback of < formatId=131077, gtrid_length=29, bqual_length=36, tx_uid=0:1:-7a70fe34:5f44ee7a:3a, node_name=1, branch_uid=0:1:-7a70fe34:5f44ee7a:3d, subordinatenodename=null, eis_name=unknown eis name > (Subordinate XAResource at remote+http://[::1]:8180) failed with exception code -: java.security.AccessControlException: WFSM000001: Permission check failed (permission "("java.io.FilePermission" "/Users/spyrkob/workspaces/set/releases/7.3.3/wildfly/testsuite/integration/multinode/target/jbossas-multinode-client/standalone/data/ejb-xa-recovery/20005_00000000000000000000000000000001858f01cc5f44ee7a0000003a31_00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000" "delete")" in code source "(vfs:/content/client.jar <no signer certificates>)" of "ModuleClassLoader for Module "deployment.client.jar" from Service Module Loader") at org.wildfly.security.manager.WildFlySecurityManager.checkPermission(WildFlySecurityManager.java:304) at org.wildfly.security.manager.WildFlySecurityManager.checkPermission(WildFlySecurityManager.java:201) at java.lang.SecurityManager.checkDelete(SecurityManager.java:1007) at org.wildfly.security.manager.WildFlySecurityManager.checkDelete(WildFlySecurityManager.java:393) at sun.nio.fs.UnixPath.checkDelete(UnixPath.java:807) at sun.nio.fs.UnixFileSystemProvider.implDelete(UnixFileSystemProvider.java:222) at sun.nio.fs.AbstractFileSystemProvider.delete(AbstractFileSystemProvider.java:103) at java.nio.file.Files.delete(Files.java:1126) at org.wildfly.transaction.client.provider.jboss.FileSystemXAResourceRegistry$XAResourceRegistryFile.removeResource(FileSystemXAResourceRegistry.java:298) at org.wildfly.transaction.client.SubordinateXAResource.rollback(SubordinateXAResource.java:213) at com.arjuna.ats.internal.jta.resources.arjunacore.XAResourceRecord.topLevelAbort(XAResourceRecord.java:362) at com.arjuna.ats.arjuna.coordinator.BasicAction.doAbort(BasicAction.java:3032) at com.arjuna.ats.arjuna.coordinator.BasicAction.doAbort(BasicAction.java:3011) at com.arjuna.ats.arjuna.coordinator.BasicAction.Abort(BasicAction.java:1674) at com.arjuna.ats.arjuna.coordinator.TwoPhaseCoordinator.cancel(TwoPhaseCoordinator.java:124) at com.arjuna.ats.arjuna.AtomicAction.abort(AtomicAction.java:186) at com.arjuna.ats.internal.jta.transaction.arjunacore.TransactionImple.rollbackAndDisassociate(TransactionImple.java:1369) at com.arjuna.ats.internal.jta.transaction.arjunacore.BaseTransaction.rollback(BaseTransaction.java:143) at com.arjuna.ats.jbossatx.BaseTransactionManagerDelegate.rollback(BaseTransactionManagerDelegate.java:139) at org.wildfly.transaction.client.LocalTransaction.rollbackAndDissociate(LocalTransaction.java:118) at org.wildfly.transaction.client.ContextTransactionManager.rollback(ContextTransactionManager.java:83) at org.wildfly.transaction.client.LocalUserTransaction.rollback(LocalUserTransaction.java:58) at org.jboss.as.test.multinode.transaction.ClientEjb.basicTransactionPropagationTest(ClientEjb.java:77) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498)

Adding a doPrivileged block in wildfly-transaction-client like: wildfly/wildfly-transaction-client@1.1...spyrkob:WEJBHTTP-47-fix seems to fix the problem.

[bstansberry]

@fl4via The failing test is in the multinode test suite. I see interesting stuff in the server.log for the server that acts as the 'client'

https://gist.github.com/bstansberry/12abd38e6e8f19e8591805be4d940785

This logging is associated with RemoteCallClientInterceptorTestCase, the test the runs just before the 1st test that fails. The log chunk shows the deploy/undeploy of the archive used by that test, followed by a server reload, which is done by that test's ServerSetup teardown method. You can see the interesting logging in the middle of the reload.

Also, in case it's useful, is that in the past the fact that CI uses -Dipv6 has resulted in it finding problems that devs didn't see themselves. Which is why CI uses -Dipv6. ;)

[bstansberry]

Closing this one as WF is up to 1.1.2.Final.