WFLY-14305 Some mistakes in Developer Guide #13898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bstansberry if you can review this :) |
github-actions
bot
added
the
deps-ok
bstansberry
requested changes
Jan 18, 2021
| libraries, it is perfectly possible to write client application that do | ||
| not use the application client, but instead use the jboss-ejb-client | ||
| Note that the application client is different from the EJB client | ||
| libraries, it is perfectly possible to write client application that does |
There was a problem hiding this comment.
s/write client/write a client/g
| not use the application client, but instead use the jboss-ejb-client | ||
| Note that the application client is different from the EJB client | ||
| libraries, it is perfectly possible to write client application that does | ||
| not uses the application client, but instead use the jboss-ejb-client |
There was a problem hiding this comment.
s/uses the/use the/g
s/instead use/instead uses/g
| @@ -16,7 +16,7 @@ Consider an application deployment which contains EJBs. EJBs typically | |||
| need access to classes from the javax.ejb.* package and other Java EE | |||
| API packages. The jars containing these packages are already shipped in | |||
| WildFly and are available as "modules". The module which contains the | |||
| javax.ejb.* classes has a specific name and so does the module which | |||
| javax.ejb.* classes have a specific name and so does the module which | |||
There was a problem hiding this comment.
"has" was correct as the subject is 'module' not 'classes'
| @@ -1,7 +1,7 @@ | |||
| [[JTA_Reference]] | |||
| = JTA Reference | |||
|
|
|||
| WildFly uses http://narayana.io[Narayana] as the implementation on of the JTA specification. | |||
| WildFly uses http://narayana.io[Narayana] as the implementation on the JTA specification. | |||
There was a problem hiding this comment.
'on' should be removed, and 'of' kept.
| @@ -169,7 +169,7 @@ NOTE: you can define the same behaviour when you use the `ejb-jar.xml` | |||
| descriptor instead of the annotations | |||
|
|
|||
| The WildFly provides specific annotation `org.jboss.ejb3.annotation.TransactionTimeout` | |||
| which gives you chance to change transaction timeout for particular bean/method. | |||
| which gives you the chance to change transaction timeout for particular bean/method. | |||
There was a problem hiding this comment.
"which gives you the chance to change the transaction timeout for a particular bean/method"
| @@ -687,7 +687,7 @@ follow the new rules. | |||
| ==== How to resolve it: | |||
|
|
|||
| To debug this, look earlier in the server log trace to what JNDI binding | |||
| were used. Looking at the server log we see this: | |||
| wes used. Looking at the server log we see this: | |||
| @@ -838,7 +838,7 @@ login with demo/demo. You should the Booking welcome page. | |||
|
|
|||
| Although it would be much more efficient to determine dependencies in | |||
| advance and add the implicit dependencies in one step, this exercise | |||
| shows how problems appear in the log and provides some information on | |||
| shows how problems appear in the log and provide some information on | |||
There was a problem hiding this comment.
'provides' was correct
|
@bstansberry Thanks for the review :) changed it accordingly. |
bstansberry
approved these changes
Jan 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://issues.redhat.com/browse/WFLY-14305
Resolving Some mistakes in Developer Guide